Skip to content

HBASE-29844 Upgrade hbase-metrics to use junit5 - #7654

Merged
taklwu merged 1 commit into
apache:masterfrom
liuxiaocs7:HBASE-29844
Jan 22, 2026
Merged

HBASE-29844 Upgrade hbase-metrics to use junit5#7654
taklwu merged 1 commit into
apache:masterfrom
liuxiaocs7:HBASE-29844

Conversation

@liuxiaocs7

@liuxiaocs7liuxiaocs7 commented Jan 21, 2026

Copy link
Copy Markdown
Member

@liuxiaocs7liuxiaocs7 changed the title HBASE-29844: Upgrade hbase-metrics to use junit5HBASE-29844 Upgrade hbase-metrics to use junit5Jan 21, 2026
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 50smaster passed
+1 💚compile0m 15smaster passed
+1 💚javadoc0m 16smaster passed
+1 💚shadedjars6m 6sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 15sthe patch passed
+1 💚compile0m 12sthe patch passed
+1 💚javac0m 12sthe patch passed
+1 💚javadoc0m 13sthe patch passed
+1 💚shadedjars7m 6spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 36shbase-metrics in the patch passed.
23m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7654
JIRA IssueHBASE-29844
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ac90a11c818e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dc9cbd2
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/testReport/
Max. process+thread count212 (vs. ulimit of 30000)
modulesC: hbase-metrics U: hbase-metrics
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 59smaster passed
+1 💚compile0m 22smaster passed
+1 💚checkstyle0m 14smaster passed
+1 💚spotbugs0m 28smaster passed
+1 💚spotless1m 3sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile0m 16sthe patch passed
+1 💚javac0m 16sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 8sthe patch passed
+1 💚xmllint0m 1sNo new issues.
+1 💚spotbugs0m 24sthe patch passed
+1 💚hadoopcheck11m 22sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
30m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7654
JIRA IssueHBASE-29844
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
unameLinux ad6cf714ac78 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dc9cbd2
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-metrics U: hbase-metrics
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall2m 35smaster passed
+1 💚compile0m 14smaster passed
+1 💚checkstyle0m 7smaster passed
+1 💚spotbugs0m 15smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 12sthe patch passed
+1 💚javac0m 12sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 5sthe patch passed
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs0m 19sthe patch passed
+1 💚hadoopcheck8m 29sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 33spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
22m 42s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7654
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
unameLinux 149219ec5cb6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f430c54
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-metrics U: hbase-metrics
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 13smaster passed
+1 💚compile0m 20smaster passed
+1 💚javadoc0m 17smaster passed
+1 💚shadedjars8m 36sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall4m 20sthe patch passed
+1 💚compile0m 15sthe patch passed
+1 💚javac0m 15sthe patch passed
+1 💚javadoc0m 13sthe patch passed
+1 💚shadedjars7m 25spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 38shbase-metrics in the patch passed.
29m 27s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7654
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d1e1a5a10336 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f430c54
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/testReport/
Max. process+thread count203 (vs. ulimit of 30000)
modulesC: hbase-metrics U: hbase-metrics
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7654/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@taklwutaklwu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to upgrade more modules to junit5 and link them to HBASE-23671 ?

@taklwu
taklwu merged commit a13d7f2 into apache:masterJan 22, 2026
2 checks passed
liuxiaocs7 added a commit to liuxiaocs7/hbase that referenced this pull request Jan 22, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
liuxiaocs7 added a commit to liuxiaocs7/hbase that referenced this pull request Jan 22, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
@liuxiaocs7

Copy link
Copy Markdown
MemberAuthor

do you plan to upgrade more modules to junit5 and link them to HBASE-23671 ?

Hi, @taklwu, sure, I’ll continue working on it.

liuxiaocs7 added a commit to liuxiaocs7/hbase that referenced this pull request Jan 23, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
PDavid pushed a commit that referenced this pull request Jan 28, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Dávid Paksy <paksyd@apache.org>
PDavid pushed a commit that referenced this pull request Jan 28, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Dávid Paksy <paksyd@apache.org>
Apache9 pushed a commit that referenced this pull request Feb 15, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Dávid Paksy <paksyd@apache.org>
(cherry picked from commit 095c7db)
Apache9 pushed a commit that referenced this pull request Feb 15, 2026
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Dávid Paksy <paksyd@apache.org>
(cherry picked from commit 095c7db)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@liuxiaocs7@Apache-HBase@taklwu