HBASE-29844 Upgrade hbase-metrics to use junit5 by liuxiaocs7 · Pull Request #7659 · apache/hbase

liuxiaocs7 · 2026-01-22T06:30:09Z

PDavid

Thanks for this. 👍

liuxiaocs7 · 2026-01-23T08:51:15Z

Hi, @ndimiduk, Yetus General Check seems fails on branch-2, could you help take a look when free, thanks! (https://github.com/apache/hbase/actions/runs/21238548792/job/61111374232?pr=7659)

maven install: branch-2
============================================================================
============================================================================
maven install: branch-2
============================================================================
============================================================================
[Thu Jan 22 06:32:31 AM UTC 2026 INFO]: Personality: branch mvninstall
[Thu Jan 22 06:32:31 AM UTC 2026 DEBUG]: Personality: clear queue
[Thu Jan 22 06:32:31 AM UTC 2026 DEBUG]: Personality: enqueue . --threads=4 -Djava.io.tmpdir=/home/runner/work/hbase/hbase/src/target -DHBasePatchProcess
[Thu Jan 22 06:32:31 AM UTC 2026 DEBUG]: MultiJDK not configured.
cd /home/runner/work/hbase/hbase/src
/opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/runner/yetus-m2/hbase-branch-2-patch-112 --threads=4 -Djava.io.tmpdir=/home/runner/work/hbase/hbase/src/target -DHBasePatchProcess -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true > /home/runner/work/hbase/hbase/yetus-general-check/output/branch-mvninstall-root.txt 2>&1
[Thu Jan 22 06:32:45 AM UTC 2026 DEBUG]: Checking for unreaped processes:
Elapsed: 0m 16s
[Thu Jan 22 06:32:47 AM UTC 2026 DEBUG]: MultiJDK not configured.
root in branch-2 failed.

ndimiduk · 2026-01-23T09:34:05Z

Looks like I don't have JDK switching tied to hadoop version switching for branch-2. HBASE-29852.

Thanks @liuxiaocs7 .

ndimiduk · 2026-01-23T09:43:42Z

#7672

liuxiaocs7 · 2026-01-23T09:49:16Z

Looks like I don't have JDK switching tied to hadoop version switching for branch-2. HBASE-29852.
Thanks @liuxiaocs7 .

Hi, @ndimiduk, got it, thanks for your quick feedback!

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>

Apache-HBase · 2026-01-23T17:50:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 52s		branch-2 passed
+1 💚	compile	0m 11s		branch-2 passed
+1 💚	javadoc	0m 12s		branch-2 passed
+1 💚	shadedjars	5m 13s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 28s		the patch passed
+1 💚	compile	0m 11s		the patch passed
+1 💚	javac	0m 11s		the patch passed
+1 💚	javadoc	0m 10s		the patch passed
+1 💚	shadedjars	5m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 19s		hbase-metrics in the patch passed.
		19m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7659
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7fcdfbfc0aa4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `667a0d9`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/testReport/
Max. process+thread count	172 (vs. ulimit of 30000)
modules	C: hbase-metrics U: hbase-metrics
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-23T17:55:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 38s		branch-2 passed
+1 💚	compile	0m 12s		branch-2 passed
+1 💚	javadoc	0m 13s		branch-2 passed
+1 💚	shadedjars	6m 26s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	0m 12s		the patch passed
+1 💚	javac	0m 12s		the patch passed
+1 💚	javadoc	0m 11s		the patch passed
+1 💚	shadedjars	6m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 22s		hbase-metrics in the patch passed.
		23m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7659
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8a882a75b47f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `667a0d9`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/testReport/
Max. process+thread count	196 (vs. ulimit of 30000)
modules	C: hbase-metrics U: hbase-metrics
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-23T18:02:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 5s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 41s		branch-2 passed
+1 💚	compile	0m 16s		branch-2 passed
+1 💚	javadoc	0m 17s		branch-2 passed
+1 💚	shadedjars	8m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 1s		the patch passed
+1 💚	compile	0m 21s		the patch passed
+1 💚	javac	0m 21s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed
+1 💚	shadedjars	8m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 34s		hbase-metrics in the patch passed.
		31m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7659
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d76aabef5f45 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `667a0d9`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/testReport/
Max. process+thread count	212 (vs. ulimit of 30000)
modules	C: hbase-metrics U: hbase-metrics
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-23T18:03:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 32s		branch-2 passed
+1 💚	compile	0m 17s		branch-2 passed
+1 💚	checkstyle	0m 9s		branch-2 passed
+1 💚	spotbugs	0m 19s		branch-2 passed
+1 💚	spotless	0m 51s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 12s		the patch passed
+1 💚	compile	0m 15s		the patch passed
+1 💚	javac	0m 15s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 8s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	0m 25s		the patch passed
+1 💚	hadoopcheck	17m 31s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		31m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7659
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux 66868f9c3f25 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `667a0d9`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-metrics U: hbase-metrics
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7659/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

liuxiaocs7 · 2026-01-28T02:17:32Z

Hi, @PDavid, thanks for reviewing, @taklwu, could you help take a look when free, thanks!

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Signed-off-by: Dávid Paksy <paksyd@apache.org> (cherry picked from commit 095c7db)

This comment has been minimized.
Sign in to view

PDavid added the backport This PR is a back port of some issue or issues already committed to master label Jan 22, 2026

PDavid approved these changes Jan 22, 2026
View reviewed changes

PDavid assigned liuxiaocs7 Jan 22, 2026

HBASE-29844 Upgrade hbase-metrics to use junit5 (apache#7654)
667a0d9
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>

liuxiaocs7 force-pushed the HBASE-29844-branch-2 branch from eab7e95 to 667a0d9Compare January 23, 2026 17:30

PDavid merged commit 095c7db into apache:branch-2Jan 28, 2026
2 checks passed

Apache9 pushed a commit that referenced this pull request Feb 15, 2026
HBASE-29844Upgrade hbase-metrics to use junit5 (#7654) (#7659)
a289a90
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Signed-off-by: Dávid Paksy <paksyd@apache.org> (cherry picked from commit 095c7db)

Apache9 pushed a commit that referenced this pull request Feb 15, 2026
HBASE-29844Upgrade hbase-metrics to use junit5 (#7654) (#7659)
c9e06ed
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Signed-off-by: Dávid Paksy <paksyd@apache.org> (cherry picked from commit 095c7db)

Navigation Menu

Uh oh!

HBASE-29844 Upgrade hbase-metrics to use junit5 - #7659

HBASE-29844 Upgrade hbase-metrics to use junit5#7659
PDavid merged 1 commit into
apache:branch-2from
liuxiaocs7:HBASE-29844-branch-2

liuxiaocs7 commented Jan 22, 2026•
edited
Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

PDavid left a comment

Uh oh!

liuxiaocs7 commented Jan 23, 2026

Uh oh!

ndimiduk commented Jan 23, 2026

Uh oh!

ndimiduk commented Jan 23, 2026

Uh oh!

liuxiaocs7 commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

liuxiaocs7 commented Jan 28, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

liuxiaocs7 commented Jan 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

PDavid left a comment

Choose a reason for hiding this comment

Uh oh!

liuxiaocs7 commented Jan 23, 2026

Uh oh!

ndimiduk commented Jan 23, 2026

Uh oh!

ndimiduk commented Jan 23, 2026

Uh oh!

liuxiaocs7 commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

Apache-HBase commented Jan 23, 2026

Uh oh!

liuxiaocs7 commented Jan 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

liuxiaocs7 commented Jan 22, 2026•
edited
Loading

liuxiaocs7 commented Jan 28, 2026•
edited
Loading