Skip to content

HIVE-28305: ProfileServlet: add html to output formats and prepare for profiler 3.0 - #5281

Merged
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:HIVE-28305
Jun 6, 2024
Merged

HIVE-28305: ProfileServlet: add html to output formats and prepare for profiler 3.0#5281
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:HIVE-28305

Conversation

@abstractdog

@abstractdogabstractdog commented Jun 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Added HTML format support to ProfileServlet.

Why are the changes needed?

Because HTML is the default format for creating flamegraphs.

Does this PR introduce any user-facing change?

No, profile servlet is more like a dev tool.

Is the change a dependency upgrade?

No.

How was this patch tested?

set web port for hs2 in hive-site.xml

+<property>
+ <name>hive.server2.webui.port</name>
+ <value>10003</value>
+</property>

#tried with both 2.9 and 3.0
export ASYNC_PROFILER_HOME=/Users/laszlobodor/Downloads/async-profiler-2.9-macos
export ASYNC_PROFILER_HOME=/Users/laszlobodor/Downloads/async-profiler-3.0-macos
mvn install -Dtest=StartMiniHS2Cluster -DminiHS2.clusterType=llap -DminiHS2.conf="target/testconf/llap/hive-site.xml" -DminiHS2.run=true -DminiHS2.usePortsFromConf=true -Dpackaging.minimizeJar=false -T 1C -DskipShade -Dremoteresources.skip=true -Dmaven.javadoc.skip=true -Denforcer.skip=true -pl itests/hive-unit -Pitests -nsu

called localhost:10003/prof and get the flamegraph successfully
https://issues.apache.org/jira/secure/attachment/13069348/async-prof-pid-21327-cpu-2.html

@abstractdogabstractdog changed the title HIVE-28305: ProfileServlet: add html to output formatsHIVE-28305: ProfileServlet: add html to output formats and prepare for profiler 3.0Jun 6, 2024
@abstractdogabstractdog mentioned this pull request Jun 6, 2024
Merged
@abstractdog
abstractdog requested a review from ayushtknJune 6, 2024 09:06
deniskuzZ
deniskuzZ reviewed Jun 6, 2024
View reviewed changes
Comment threadcommon/src/java/org/apache/hive/http/ProfileServlet.java
deniskuzZ
deniskuzZ reviewed Jun 6, 2024
View reviewed changes
Comment threadcommon/src/java/org/apache/hive/http/ProfileServlet.java Outdated
deniskuzZ
deniskuzZ approved these changes Jun 6, 2024
View reviewed changes

@deniskuzZdeniskuzZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

@sonarqubecloud

sonarqubecloudBot commented Jun 6, 2024

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ayushtkn
ayushtkn approved these changes Jun 6, 2024
View reviewed changes

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadcommon/src/java/org/apache/hive/http/ProfileServlet.java Outdated
return Output.valueOf(outputArg.trim().toUpperCase());
} catch (IllegalArgumentException e) {
return Output.SVG;
LOG.warn("Output format value is invalid, returning with default HTML");

@ayushtknayushtknJun 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add what value is actually configured in the log as well

 LOG.warn("Output format value {} is invalid, returning with default HTML", outputArg);

@abstractdogabstractdogJun 6, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!
took care in 681036c

@abstractdog

abstractdog commented Jun 6, 2024

Copy link
Copy Markdown
ContributorAuthor

all tests passed, merging
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5281/3/pipeline

@abstractdog
abstractdog merged commit 521c5fd into apache:masterJun 6, 2024
asfgit pushed a commit that referenced this pull request Sep 23, 2024
@abstractdog@ayushtkn
HIVE-28305: ProfileServlet: add html to output formats and prepare fo…
00abddb
…r profiler 3.0 (#5281) (Laszlo Bodor reviewed by Denys Kuzmenko, Ayush Saxena, Kokila N)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deniskuzZdeniskuzZdeniskuzZ approved these changes
@ayushtknayushtknayushtkn approved these changes
+1 more reviewer
@kokila-19kokila-19kokila-19 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abstractdog@deniskuzZ@ayushtkn@kokila-19@asf-ci-hive