Skip to content

TEZ-4568: ProfileServlet: add html to output formats and prepare for profiler 3.0 - #360

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4568
Jun 6, 2024
Merged

TEZ-4568: ProfileServlet: add html to output formats and prepare for profiler 3.0#360
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4568

Conversation

@abstractdog

@abstractdogabstractdog commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

This PR is for fixing the same problems as mentioned and tested in HIVE-28305
please look at that PR for details:
apache/hive#5281

@tez-yetus

This comment was marked as outdated.

@abstractdog
abstractdogforce-pushed the TEZ-4568 branch 2 times, most recently from 712c6d1 to 169c8a4CompareJune 6, 2024 09:01
@abstractdogabstractdog changed the title TEZ-4568: ProfileServlet: add html to output formatsTEZ-4568: ProfileServlet: add html to output formats and prepare for profiler 3.0Jun 6, 2024
@abstractdog
abstractdog requested a review from ayushtknJune 6, 2024 09:05
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 54smaster passed
+1 💚compile0m 17smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚compile0m 16smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚checkstyle1m 15smaster passed
+1 💚javadoc0m 37smaster passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc0m 14smaster passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 🆗spotbugs1m 2sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 2smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 10sthe patch passed
+1 💚compile0m 10sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javac0m 10sthe patch passed
+1 💚compile0m 10sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚javac0m 10sthe patch passed
+1 💚checkstyle0m 5sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 7sthe patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚javadoc0m 7sthe patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚findbugs0m 25sthe patch passed
_ Other Tests _
+1 💚unit0m 28stez-common in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
21m 18s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-360/4/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 0e53db02f7f8 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 38c5aac
Default JavaPrivate Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-360/4/testReport/
Max. process+thread count101 (vs. ulimit of 5500)
modulesC: tez-common U: tez-common
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-360/4/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog merged commit e08d027 into apache:masterJun 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn