Implement update for `remove-snapshot-ref` action by grihabor · Pull Request #1598 · apache/iceberg-python

grihabor · 2025-02-01T09:13:59Z

Part of #1561
Closes#822

Fokko

Left some style suggestions, but apart from that, it looks good to me 👍

Fokko · 2025-02-03T11:13:05Z

Thanks for splitting this out 👍

Co-authored-by: Fokko Driesprong <fokko@apache.org>

grihabor · 2025-02-10T09:49:57Z

@Fokko Thank you for review! Ready for another round

grihabor · 2025-02-10T17:50:30Z

looks like 3.12 failed because of some flaky build:

failed to solve: process "/bin/sh -c curl --retry 5 -s -C - [https://archive.apache.org/dist/spark/spark-${SPARK_VERSION}/spark-${SPARK_VERSION}-bin-hadoop3.tgz](https://archive.apache.org/dist/spark/spark-$%7BSPARK_VERSION%7D/spark-$%7BSPARK_VERSION%7D-bin-hadoop3.tgz) -o spark-${SPARK_VERSION}-bin-hadoop3.tgz && tar xzf spark-${SPARK_VERSION}-bin-hadoop3.tgz --directory /opt/spark --strip-components 1 && rm -rf spark-${SPARK_VERSION}-bin-hadoop3.tgz" did not complete successfully: exit code: 28

kevinjqliu · 2025-02-10T17:57:08Z

I retrigger the test, we get intermittent failures from apache archive link

grihabor · 2025-02-10T22:37:53Z

Thank you! It passed now

grihabor · 2025-02-13T21:42:15Z

@kevinjqliu @Fokko Shall we merge this?

Fokko · 2025-02-14T19:42:24Z

@grihabor Sorry for not following up here, thanks for adding this, let's get this in 🚀

Bumps [psycopg2-binary](https://github.com/psycopg/psycopg2) from 2.9.10 to 2.9.11. <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/psycopg/psycopg2/blob/master/NEWS">psycopg2-binary's changelog</a>. <blockquote> <h2>Current release</h2> What's new in psycopg 2.9.11 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li>Add support for Python 3.14.</li> <li>Avoid a segfault passing more arguments than placeholders if Python is built with assertions enabled (:ticket:<code>[#1791](https://github.com/psycopg/psycopg2/issues/1791)</code>).</li> <li><code>~psycopg2.errorcodes</code> map and <code>~psycopg2.errors</code> classes updated to PostgreSQL 18.</li> <li>Drop support for Python 3.8.</li> </ul> What's new in psycopg 2.9.10 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li>Add support for Python 3.13.</li> <li>Receive notifications on commit (:ticket:<code>[#1728](https://github.com/psycopg/psycopg2/issues/1728)</code>).</li> <li><code>~psycopg2.errorcodes</code> map and <code>~psycopg2.errors</code> classes updated to PostgreSQL 17.</li> <li>Drop support for Python 3.7.</li> </ul> What's new in psycopg 2.9.9 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li>Add support for Python 3.12.</li> <li>Drop support for Python 3.6.</li> </ul> What's new in psycopg 2.9.8 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li>Wheel package bundled with PostgreSQL 16 libpq in order to add support for recent features, such as <code>sslcertmode</code>.</li> </ul> What's new in psycopg 2.9.7 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li>Fix propagation of exceptions raised during module initialization (:ticket:<code>[#1598](https://github.com/psycopg/psycopg2/issues/1598)</code>).</li> <li>Fix building when pg_config returns an empty string (:ticket:<code>[#1599](https://github.com/psycopg/psycopg2/issues/1599)</code>).</li> <li>Wheel package bundled with OpenSSL 1.1.1v.</li> </ul> What's new in psycopg 2.9.6 ^^^^^^^^^^^^^^^^^^^^^^^^^^^  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/psycopg/psycopg2/commit/fd9ae8cad2bcfc3e7e9410e7b6f07cda8f4f05ec"><code>fd9ae8c</code></a> chore: bump to version 2.9.11</li> <li><a href="https://github.com/psycopg/psycopg2/commit/d923840546942534f0956d9202f914fd9feac5fd"><code>d923840</code></a> chore: update docs requirements</li> <li><a href="https://github.com/psycopg/psycopg2/commit/d42dc7169d3cd93517e282e9ef5dc2a2b40650a2"><code>d42dc71</code></a> Merge branch 'fix-1791'</li> <li><a href="https://github.com/psycopg/psycopg2/commit/4fde6560c32f06ad1304404c9f7f86148dcc4be0"><code>4fde656</code></a> fix: avoid failed assert passing more arguments than placeholders</li> <li><a href="https://github.com/psycopg/psycopg2/commit/8308c19d6af0d904b313997539ed33415990a74e"><code>8308c19</code></a> fix: drop warning about the use of deprecated PyWeakref_GetObject function</li> <li><a href="https://github.com/psycopg/psycopg2/commit/1a1eabf098a3374409bb2ab4b594777b900f396d"><code>1a1eabf</code></a> build(deps): bump actions/github-script from 7 to 8</li> <li><a href="https://github.com/psycopg/psycopg2/commit/897af8b38beda851d7257dfc525129e37c0ec9e0"><code>897af8b</code></a> build(deps): bump peter-evans/repository-dispatch from 3 to 4</li> <li><a href="https://github.com/psycopg/psycopg2/commit/ceefd305117113ca10e383a626e87ba0796f3638"><code>ceefd30</code></a> build(deps): bump actions/checkout from 4 to 5</li> <li><a href="https://github.com/psycopg/psycopg2/commit/4dc585430cabe94cee96c5a9de0265d0f55370f1"><code>4dc5854</code></a> build(deps): bump actions/setup-python from 5 to 6</li> <li><a href="https://github.com/psycopg/psycopg2/commit/1945788dcf6172bb1b9328ebc3587ccf0e6a659c"><code>1945788</code></a> Merge pull request <a href="https://redirect.github.com/psycopg/psycopg2/issues/1802">#1802</a> from edgarrmondragon/cp314-wheels</li> <li>Additional commits viewable in <a href="https://github.com/psycopg/psycopg2/compare/2.9.10...2.9.11">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=psycopg2-binary&package-manager=pip&previous-version=2.9.10&new-version=2.9.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

grihabor added 2 commits February 1, 2025 10:11

cherry-pick: Support Remove Branch or Tag APIs (apache#822)
7093ec1

Add unit test
78e263d

grihabor marked this pull request as ready for review February 1, 2025 09:29

grihabor added a commit to grihabor/iceberg-python that referenced this pull request Feb 1, 2025
Revert changes (moved toapache#1598)
32e1e85

Allow removing main branch
4d14181

grihabor mentioned this pull request Feb 1, 2025
Implement update for remove-snapshots action #1561
Merged