Skip to content

Add test to ensure every table update has corresponding _apply_table_update function - #952

Closed
kevinjqliu wants to merge 4 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/enforce-table-update-dispatch
Closed

Add test to ensure every table update has corresponding _apply_table_update function#952
kevinjqliu wants to merge 4 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/enforce-table-update-dispatch

Conversation

@kevinjqliu

@kevinjqliukevinjqliu commented Jul 21, 2024

Copy link
Copy Markdown
Contributor

This PR adds a test in to check that every TableUpdate class has a corresponding _apply_table_update function.

While looking at #864 and #950, I noticed that some TableUpdate classes do not have corresponding _apply_table_update function.
I think we should enforce this in tests so that any future TableUpdate have the necessary _apply_table_update to process the update.

@kevinjqliu
kevinjqliuforce-pushed the kevinjqliu/enforce-table-update-dispatch branch from be27ba3 to edf0c17CompareAugust 7, 2024 18:00
@kevinjqliukevinjqliu changed the title add testAdd test to ensure every table update has corresponding _apply_table_update functionAug 7, 2024
@kevinjqliukevinjqliu added this to the PyIceberg 0.9.0 release milestone Oct 30, 2024
@kevinjqliu
kevinjqliuforce-pushed the kevinjqliu/enforce-table-update-dispatch branch from edf0c17 to c5bcea7CompareNovember 3, 2024 00:22
@kevinjqliukevinjqliu removed this from the PyIceberg 0.9.0 release milestone Feb 1, 2025
@grihabor

grihabor commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

@kevinjqliu Since these 2 prs #1598#1561 are now in main, I believe you can now rebase and merge this one

@kevinjqliu

Copy link
Copy Markdown
ContributorAuthor

Amazing! @grihabor thanks for the ping, let me rebase this PR

@kevinjqliu
kevinjqliu marked this pull request as ready for review February 19, 2025 16:53
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinjqliu@grihabor