Add TIME_MICROS support to GenericParquetReaders - #487
Merged
Conversation
rdblue
reviewed
Sep 20, 2019
rdblue
reviewed
Sep 20, 2019
| import java.time.OffsetDateTime; | ||
| import java.time.ZoneOffset; | ||
|
|
||
| import java.time.*; |
Contributor
There was a problem hiding this comment.
We avoid wildcard imports because it isn't clear where symbols are coming from and there is potential for collision. Could you roll back this change? (As well as the additional newline, we don't use breaks in imports either.)
Contributor
|
Thanks for working on this, @ashleycoxley! |
Contributor
|
Looks like there are checkstyle violations: |
Contributor
|
Merged! Thanks for the quick updates, @ashleycoxley! If you'd like to open a PR for |
Contributor
|
I've created an issue to support |
Contributor
|
Thanks, Anton! |
Contributor
Author
|
Thanks both! I'll plan to pick that up soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482