Skip to content

Add TIME_MICROS support to GenericParquetReaders #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 3 commits into from
Sep 23, 2019
Merged

Add TIME_MICROS support to GenericParquetReaders #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
530f4af
Add TIME_MICROS support to GenericParquetReaders
ashleycoxley Sep 20, 2019
facf399
updates per review
ashleycoxley Sep 21, 2019
cc11ea6
Style updates
ashleycoxley Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.time.Instant;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.time.OffsetDateTime;
import java.time.ZoneOffset;
import java.time.temporal.ChronoUnit;
Expand Down Expand Up @@ -229,6 +230,8 @@ public ParquetValueReader<?> primitive(org.apache.iceberg.types.Type.PrimitiveTy
} else {
return new TimestampMillisReader(desc);
}
case TIME_MICROS:
return new TimeReader(desc);
case DECIMAL:
DecimalMetadata decimal = primitive.getDecimalMetadata();
switch (primitive.getPrimitiveTypeName()) {
Expand Down Expand Up @@ -366,6 +369,17 @@ public OffsetDateTime read(OffsetDateTime reuse) {
}
}

private static class TimeReader extends PrimitiveReader<LocalTime> {
private TimeReader(ColumnDescriptor desc) {
super(desc);
}

@Override
public LocalTime read(LocalTime reuse) {
return LocalTime.ofNanoOfDay(column.nextLong() * 1000L);
}
}

private static class FixedReader extends PrimitiveReader<byte[]> {
private FixedReader(ColumnDescriptor desc) {
super(desc);
Expand Down
3 changes: 2 additions & 1 deletion data/src/test/java/org/apache/iceberg/data/DataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ public abstract class DataTest {
optional(113, "bytes", Types.BinaryType.get()),
required(114, "dec_9_0", Types.DecimalType.of(9, 0)),
required(115, "dec_11_2", Types.DecimalType.of(11, 2)),
required(116, "dec_38_10", Types.DecimalType.of(38, 10)) // maximum precision
required(116, "dec_38_10", Types.DecimalType.of(38, 10)), // maximum precision
required(117, "time", Types.TimeType.get())
);

@Rule
Expand Down