Skip to content

Pipe: Fixed the OPC UA bug that drop pipe may not erase the client - #17510

Merged
jt2594838 merged 1 commit into
masterfrom
log-bishop
Apr 20, 2026
Merged

Pipe: Fixed the OPC UA bug that drop pipe may not erase the client#17510
jt2594838 merged 1 commit into
masterfrom
log-bishop

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecovBot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.87%. Comparing base (89c2af8) to head (1b028b8).
⚠️ Report is 7 commits behind head on master.

Files with missing linesPatch %Lines
...e/iotdb/db/pipe/sink/protocol/opcua/OpcUaSink.java50.00%9 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #17510 +/- ##
============================================
- Coverage 39.87% 39.87% -0.01% 
Complexity 312 312 ============================================
Files 5137 5137 Lines 347145 347143 -2 Branches 44246 44246 ============================================
- Hits 138413 138407 -6 - Misses 208732 208736 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit a3c451e into masterApr 20, 2026
30 checks passed
@jt2594838
jt2594838 deleted the log-bishop branch April 20, 2026 06:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Caideyipi@jt2594838