Skip to content

[To dev/1.3] Pipe: Fixed the OPC UA bug that drop pipe may not erase the client (#17510) - #17522

Merged
jt2594838 merged 1 commit into
dev/1.3from
drop-erase
Apr 21, 2026
Merged

[To dev/1.3] Pipe: Fixed the OPC UA bug that drop pipe may not erase the client (#17510)#17522
jt2594838 merged 1 commit into
dev/1.3from
drop-erase

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecovBot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.57%. Comparing base (413b074) to head (728ec16).
⚠️ Report is 1 commits behind head on dev/1.3.

Files with missing linesPatch %Lines
...e/iotdb/db/pipe/sink/protocol/opcua/OpcUaSink.java50.00%9 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## dev/1.3 #17522 +/- ##
=============================================
- Coverage 41.58% 41.57% -0.01% 
Complexity 227 227 =============================================
Files 3597 3597 Lines 236918 236916 -2 Branches 28673 28673 =============================================
- Hits 98514 98509 -5 - Misses 138404 138407 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit c155666 into dev/1.3Apr 21, 2026
19 of 20 checks passed
@jt2594838
jt2594838 deleted the drop-erase branch April 21, 2026 03:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Caideyipi@jt2594838