Skip to content

Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close - #17549

Merged
jt2594838 merged 2 commits into
masterfrom
disruptor
Apr 28, 2026
Merged

Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close#17549
jt2594838 merged 2 commits into
masterfrom
disruptor

Conversation

@Caideyipi

@CaideyipiCaideyipi commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Before this PR, an empty realtime pipe may consume lots of time to close. The PR has checked the circumstance, where the pipe can be directly dropped now.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecovBot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.10638% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.84%. Comparing base (859c719) to head (6d591e9).
⚠️ Report is 7 commits behind head on master.

Files with missing linesPatch %Lines
...region/realtime/disruptor/BatchEventProcessor.java82.14%5 Missing ⚠️
...ource/dataregion/realtime/disruptor/Disruptor.java66.66%1 Missing ⚠️
...altime/listener/PipeInsertionDataNodeListener.java93.33%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #17549 +/- ##
=========================================
Coverage 39.83% 39.84% Complexity 2539 2539 =========================================
Files 5171 5171 Lines 348095 348123 +28 Branches 44474 44480 +6 =========================================
+ Hits 138677 138710 +33 + Misses 209418 209413 -5 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
if (extractor.isNeedListenToInsertNode()) {
listenToInsertNodeExtractorCount.decrementAndGet();
assigner.stopAssignTo(extractor);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source?

@jt2594838
jt2594838 merged commit 6680d6f into masterApr 28, 2026
29 of 30 checks passed
@jt2594838
jt2594838 deleted the disruptor branch April 28, 2026 07:05
jt2594838 pushed a commit that referenced this pull request Apr 30, 2026
…erence & will wait long time after pipe close (#17549) (#17569)
* Pipe: Implementing DisruptorQueue (#16639)
* Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close (#17549)
* fix
* fix
* del
---------
Co-authored-by: Zhenyu Luo <zhenyu@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Caideyipi@jt2594838