Skip to content

Revert "Fix CQ recovery gap and stale callback contamination (#17734)" - #17827

Merged
Caideyipi merged 1 commit into
masterfrom
re-cq
Jun 3, 2026
Merged

Revert "Fix CQ recovery gap and stale callback contamination (#17734)"#17827
Caideyipi merged 1 commit into
masterfrom
re-cq

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

This reverts commit 29d0d51.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi
Caideyipi merged commit a420681 into masterJun 3, 2026
41 checks passed
@Caideyipi
Caideyipi deleted the re-cq branch June 3, 2026 04:26
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate FailedQuality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov

codecovBot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.15385% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.86%. Comparing base (011bdec) to head (d3bf44f).
⚠️ Report is 1 commits behind head on master.

Files with missing linesPatch %Lines
...apache/iotdb/confignode/persistence/cq/CQInfo.java26.31%14 Missing ⚠️
...onfignode/procedure/impl/cq/CreateCQProcedure.java40.00%6 Missing ⚠️
...he/iotdb/confignode/manager/cq/CQScheduleTask.java0.00%5 Missing ⚠️
...gnode/consensus/request/write/cq/ActiveCQPlan.java71.42%2 Missing ⚠️
...fignode/consensus/request/write/cq/DropCQPlan.java71.42%2 Missing ⚠️
...sus/request/write/cq/UpdateCQLastExecTimePlan.java71.42%2 Missing ⚠️
.../apache/iotdb/confignode/manager/cq/CQManager.java0.00%2 Missing ⚠️
...nfignode/consensus/request/write/cq/AddCQPlan.java85.71%1 Missing ⚠️
...gnode/persistence/executor/ConfigPlanExecutor.java0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #17827 +/- ##
============================================
- Coverage 40.90% 40.86% -0.05% - Complexity 2610 2611 +1 
============================================
Files 5186 5186 Lines 351420 351308 -112 Branches 44991 44971 -20 ============================================
- Hits 143758 143559 -199 - Misses 207662 207749 +87 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Caideyipi added a commit that referenced this pull request Jun 3, 2026
MileaRobertStefan pushed a commit to MileaRobertStefan/iotdb that referenced this pull request Jun 26, 2026
MileaRobertStefan pushed a commit to MileaRobertStefan/iotdb that referenced this pull request Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Caideyipi