Skip to content

Apply “draft trick” to process-dependabot-reusable.yaml - #475

Merged
ppkarwasz merged 1 commit into
gha/v0from
feat/draft-trick
Jun 18, 2026
Merged

Apply “draft trick” to process-dependabot-reusable.yaml#475
ppkarwasz merged 1 commit into
gha/v0from
feat/draft-trick

Conversation

@ppkarwasz

Copy link
Copy Markdown
Member

This change applies the “draft trick” to process-dependabot-reusable.yaml: instead of enabling “auto-merge” on the PR, it puts it into draft mode. This allows the removal of a PAT at the cost of two additional actions for maintainers that need to:

  1. Approve the PR,
  2. Put it into “Ready for review” state. If workflows are listening to ready_for_review, they will start,
  3. Enable “auto-merge” on the PR.

This change applies the “draft trick” to `process-dependabot-reusable.yaml`: instead of enabling “auto-merge” on the PR, it puts it into draft mode. This allows the removal of a PAT at the cost of two additional actions for maintainers that need to:
1. Approve the PR,
2. Put it into “Ready for review” state. If workflows are listening to `ready_for_review`, they will start,
3. Enable “auto-merge” on the PR.
@ppkarwaszppkarwasz mentioned this pull request May 3, 2026
vy
vy approved these changes May 18, 2026
@ppkarwasz
ppkarwasz merged commit 917fa91 into gha/v0Jun 18, 2026
2 checks passed
@ppkarwasz
ppkarwasz deleted the feat/draft-trick branch June 18, 2026 06:19
ppkarwasz added a commit that referenced this pull request Jun 18, 2026
* Document “draft trick”
This change documents the “draft trick” introduced in #475 and applies it to the `main` branch.
* fix: remove PAT references
ppkarwasz added a commit that referenced this pull request Jul 24, 2026
Since the required build checks can now be started with the "Approve
workflows to run" button, restore the pre-#475 behavior of enabling
"auto-merge" on the PR: after a maintainer approves the PR and its
workflow runs, the PR merges automatically once the required checks pass.
Assisted-By: Claude Fable 5 <noreply@anthropic.com>
ppkarwasz added a commit that referenced this pull request Jul 24, 2026
* Don't switch to "Draft mode"
Since GitHub's June 11, 2026 change "Bot-created pull requests can run
workflows if approved"[1], workflows triggered by the "Process Dependabot
PR" push are no longer silently dropped, but created in an
approval-required state. A maintainer can start the required build checks
with the "Approve workflows to run" button, so parking the PR in draft
mode is no longer necessary.
Also drop the `pull-requests: write` permission, which was only needed to
toggle draft mode, and explicitly opt into `persist-credentials` for the
checkout, since the changelog commit push relies on it.
[1] https://github.blog/changelog/2026-06-11-bot-created-pull-requests-can-run-workflows-if-approved/
Assisted-By: Claude Fable 5 <noreply@anthropic.com>
* Enable auto-merge instead
Since the required build checks can now be started with the "Approve
workflows to run" button, restore the pre-#475 behavior of enabling
"auto-merge" on the PR: after a maintainer approves the PR and its
workflow runs, the PR merges automatically once the required checks pass.
Assisted-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ppkarwasz@vy