Uh oh!
There was an error while loading. Please reload this page.
Don't switch to "Draft mode" - #500
Merged
Merged
Conversation
Since GitHub's June 11, 2026 change "Bot-created pull requests can run workflows if approved"[1], workflows triggered by the "Process Dependabot PR" push are no longer silently dropped, but created in an approval-required state. A maintainer can start the required build checks with the "Approve workflows to run" button, so parking the PR in draft mode is no longer necessary. Also drop the `pull-requests: write` permission, which was only needed to toggle draft mode, and explicitly opt into `persist-credentials` for the checkout, since the changelog commit push relies on it. [1] https://github.blog/changelog/2026-06-11-bot-created-pull-requests-can-run-workflows-if-approved/ Assisted-By: Claude Fable 5 <noreply@anthropic.com>
ppkarwasz
commented
Jul 24, 2026
MemberAuthor
Maybe we can also reenable “Auto-merge”, so we need one less click. I'll modify the PR to do it. |
Since the required build checks can now be started with the "Approve workflows to run" button, restore the pre-#475 behavior of enabling "auto-merge" on the PR: after a maintainer approves the PR and its workflow runs, the PR merges automatically once the required checks pass. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
ppkarwasz
enabled auto-merge (squash)
July 24, 2026 10:34
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 24, 2026
ramanathan1504 pushed a commit
to apache/logging-log4j2
that referenced
this pull request
Aug 18, 2026
Since apache/logging-parent#500 has been merged, workflow runs no longer need to be triggered by PR events of type `ready_for_review`. We therefore remove the `pull_request.types` filter entirely, which restores the default event types. We also simplify the `branches` filters on the `push` and `pull_request` triggers. Since this workflow file lives on `2.x`, these filters only affect `2.x` itself and branches created from it: - For `push`: only `release/2*` branches automatically inherit these workflows. We drop `2.25.x` (in `build`) and `main` (in `codeql-analysis`), since those entries would only be useful if we were to branch `2.25.x` or `main` anew from `2.x`. Keeping them would confuse readers of the workflow file. - For `pull_request`: all branches will run these workflows if a PR is opened against them (e.g. "stacked" PRs opened against the branch of another PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GitHub's June 11, 2026 change "Bot-created pull requests can run workflows if approved", workflows triggered by the "Process Dependabot PR" push are no longer silently dropped, but created in an approval-required state. A maintainer can start the required build checks with the "Approve workflows to run" button, so parking the PR in draft mode is no longer necessary.
Also drop the
pull-requests: writepermission, which was only needed to toggle draft mode, and explicitly opt intopersist-credentialsfor the checkout, since the changelog commit push relies on it.Assisted-By: Claude Fable 5 noreply@anthropic.com