Uh oh!
There was an error while loading. Please reload this page.
fix(modules): unbox 每日回顾 + 定时任务, converge daily-review onto the house language - #1187
Merged
Conversation
The 定时任务 (.maka-plan-shell) and 每日回顾 (.maka-module-main .maka-daily-review-panel) wrappers each carried full card chrome (card-bg + hairline + radius-surface + card-shadow + padding) around the whole module, wrapping it in a second frame the MCP page never had. Inner surfaces (system alert, task cards, run rows, archive body, stat tiles, alerts) already carry their own borders, so the wrapper read as box-in-box and crowded the module subtitle. Both are plain layout containers now: chrome stripped, padding 0, layout properties kept, daily-review width converged 980 -> 900 to track the module header measure. Content sits flush with the module header like the skills (#1185) / MCP pages. radius-converge entries for both selectors re-pinned with the established unboxing note. Follows the #1185 skills-unbox precedent.
Presentation-only pass bringing 每日回顾 in line with the skills / MCP pages (zero behavior change — same data, actions, IPC): - Section headers: 活跃对话 / 模型使用 / 工具调用 rendered a hand-rolled uppercase eyebrow with a bespoke accent bar — the exact dialect section-header.tsx was built to retire — while 已生成报告 on the same page already used the SectionHeader primitive. All section titles now render through SectionHeader (as=h4, accent) so the page speaks one section-header language. Dropped the .maka-daily-review-section-title + ::before CSS. - Stepper: the ‹ › day-navigation controls used bare text glyphs on a ghost icon button; swapped to ChevronLeft / ChevronRight from @maka/ui/icons (icon-governance: no strokeWidth at the callsite). - Retry alert: .maka-daily-review-alert re-implemented the warning surface (flex row + hairline + tint + radius) by hand, fighting the Alert primitive's grid slot layout. Dropped the bespoke chrome; the warning variant owns border / tint / radius / padding and the description-action split. Kept .maka-daily-review-alert-retry flex:none. - Section divider token converged 0.07-alpha -> --foreground-10 to match the header / quick-runs / archives dividers on the same page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1185 (skills unbox), user-confirmed: the same outer card frame wraps 每日回顾 and 定时任务 — both removed — plus the requested daily-review restyle (不太符合我们的风格 → 重构和优化和美化). One batched PR.
Unbox (same pattern as #1185)
Daily-review restyle (presentation-only, zero behavior change)
StatTile/Item/Chip/Segmented/EmptyState usage was already on-language and untouched.
Gates
Tree already contains current main tip. desktop 2695/2695 · ui 183/183 · typecheck · check-dead-css · knip ×2 = 0 · alignment auditor clean · console/a11y/copy checks 0. CDP light+dark before/after on both pages: frame gone, content flush, each inner card keeps its border; skills page byte-equivalent (untouched). Implemented by an opus worktree agent; verified post-merge.