Uh oh!
There was an error while loading. Please reload this page.
feat(daily-review): IA redesign — 每日回顾 从控件汤到清晰的三段式 - #1191
Merged
Conversation
The run model-option default read 使用设置中的分析模型 — too long for the compact picker that now rides the PageHeader actions slot (it wrapped to two lines). Shorten to 跟随设置; a run with no explicit override still falls back to the model configured in Settings (behavior unchanged — the sentinel value and bridge mapping are untouched).
The page was 很乱/很不好用: two floating control rows with unclear ownership, a broken master-detail archive list that left its left column half-empty, a status Chip on the EXPECTED 已生成 state (#651), a floating orphan line at the page bottom, and a stats section that vanished entirely on a no-activity day. Rebuild the information architecture (zero data/IPC/behavior change — same props, callbacks, guards; contract-pinned run/copy/archive plumbing preserved): - PageHeader is the page shell: title + subtitle, and the 生成每日回顾 / 生成深度分析 actions ride its actions slot (skills-page pattern). The analysis model select is now a COMPACT generation option in that same cluster, not a page-wide row. Header moves into the panel so the actions can compose with the panel's run state; the bridge-less fallback keeps its own static header. - ONE time-scope row under the header: the 今日/本周/本月 segmented + the day-stepper are one visual cluster (both are time navigation) instead of two widgets at opposite page corners. - 概览 section is ALWAYS rendered: SectionHeader + the StatTile row shown with honest zeros even on a no-activity scope, plus one inline muted hint. This absorbs the old bottom-of-page orphan line, which is deleted — the stats section no longer disappears into a hole. - 报告 section replaces the broken master-detail with a stacked, newest-first list of full-width report surfaces. Each shows an always-visible meta head (date · 模式 · N 对话 · 触发+时间 · 模型 as muted prose — NO 已生成 chip); the selected report expands its four content sections in place. Status color is exception-only now: only 生成失败 / 缺少模型 raise a Chip. Single-selection lazy body load (getArchive) is unchanged — the archive-body-load contract pins that path. - Empty report state is the EmptyState primitive with a CTA wired to 生成每日回顾 (respects the pending/running guards). - Export (复制/粘到输入框/保存) rides the 概览 SectionHeader action slot, gated to a non-empty scope (guard shape pinned by the copy-feedback contract). Re-pin: radius-converge-contract's .maka-daily-review-archive-body surface entry follows the rename to .maka-daily-review-report (the surface owns the radius; the expanded body divides with a hairline).
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User verdict on the old page: 很混乱、很不好看、很不好用. This is the IA redesign (the #1187 style pass converged primitives; this round restructures the page).
Problems fixed (diagnosed from live captures)
Fidelity
Zero data/IPC/behavior change — same props, callbacks, and fail-soft guards; copy-feedback and archive-body-load contracts preserved verbatim; radius contract re-pinned for the archive-body → report surface rename. Documented deviations: export actions stay with the 概览 stats they serialize (contract pins the visibleSummary guard); accordion over all-expanded (avoids N eager body fetches).
Gates
Branch already contains main tip. desktop 2695/2695 · ui 183/183 · typecheck · check-dead-css · knip ×2 = 0 · console/a11y/copy checks OK · alignment auditor clean. CDP before/after light+dark verified (captures in session scratchpad only). Implemented by an opus worktree agent from a maintainer-authored IA brief; visually accepted before merge.