Uh oh!
There was an error while loading. Please reload this page.
fix(mcp): real brand marks for 钉钉 / 飞书 / macOS 应用 - #1236
Merged
Conversation
The MCP catalog's last three text-mark tiles (钉/飞/⌘) now render official library brand marks on the neutral data-logo plate, matching the simple-icons tiles. Unifies the mark model behind a per-source viewBox so 24-viewBox and 896-viewBox sources coexist without rescaling. - macOS 应用 → Apple: siApple from the existing simple-icons dep (hex 000000; the dark-plate luminance gate flips it to currentColor → white in dark). - 钉钉 → DingTalk: new dep @ant-design/icons-svg (Ant Group's first-party lib; DingTalk is an Alibaba product). Deep-imports only the DingtalkOutlined asn AST (tree-shakes; +1.3KB to index, no separate chunk). Chose the OUTLINED bare-pigeon silhouette over DingtalkCircleFilled so it reads like the other bare-glyph tiles instead of a solid disc. Filled DingTalk blue #0089FF. - 飞书 → Feishu: monochrome mark vendored byte-for-byte from ByteDance's own @douyinfe/semi-icons (MIT; Feishu is a ByteDance product) as path constants — mirrors provider-brand-marks' single-mark vendoring rather than adding a React-coupled 3k-file dep. Filled Feishu blue #3370FF. Cleanup: drop the 钉/飞/⌘ text marks (mark is now optional); remove the dead --brand-dingtalk / --brand-feishu tokens + their tinted-plate CSS (these tiles now ride the neutral logo plate). Refresh the icon-governance allowlist rationale to name all three mark sources. Verified: typecheck, desktop suite (2729), ui suite (191), knip ×2, check-dead-css, audit-alignment (module-mcp clean) all green; CDP light+dark captures show all three real marks (Apple flips white in dark; DingTalk/Feishu stay blue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-requested completion of the MCP brand-mark work: the last three text-mark tiles (钉/飞/⌘) become real official marks. A prior attempt was lost to a process crash; this is the clean retry with maintainer-verified sourcing facts baked in.
Sources (all first-party, nothing hand-drawn)
Mechanics
Mark model generalized to {paths[], viewBox, hex} so 24-viewBox (simple-icons/semi) and 896-viewBox (ant) sources coexist; luminance gate + neutral logo plate unchanged. Text marks and their now-dead --brand-* tokens/tint CSS removed. Governance allowlist unchanged in shape; rationale comment updated to name all three sources. Bundle delta +1.3KB (ant tree-shook to one AST; verified no side chunk).
Gates
Tree already contains main tip. desktop 2729/2729 · ui 191/191 · typecheck · check-dead-css · knip ×2 (new dep declared+consumed) · alignment auditor exit 0. CDP light+dark captures visually accepted by maintainer (14 tiles, 10 real marks). Implemented by an opus worktree agent.