Uh oh!
There was an error while loading. Please reload this page.
chore(frontend): 2026-07-19 architecture + UI-delta campaign — map, knip zero-hint, resume hook, QR fixture - #1241
Merged
Merged
Conversation
… rounds (2026-07-19) Re-ran the census (wc over non-test TS/TSX for desktop main/preload/renderer + packages/ui; CSS totals; top-10 hotspot table incl. visual-smoke-fixture.ts marked OUT-OF-SCOPE other-sessions' territory). Staged R1 knip de-rot, R2 app-shell resume-cluster extraction, R3 visual-smoke split (BLOCKED on concurrent fixture branch), R4-R6 main.ts extractions (require maintainer-approved contract re-pins — registerIpc / startup / tool-assembly / modelSupportsVision direct-pinned), R7 provider-connection-detail decomposition (needs its own blade plan), R8 CSS raw-hex residue (verified clean on this tip — #1085 already converted it).
knip reported 13 configuration hints (7 desktop + 6 ui), all redundant/stale config, zero code impact: - Drop 'overlayscrollbars' from desktop ignoreDependencies — now redundant (knip no longer flags it; the package is owned by packages/ui and only referenced there). The overlay-scrollbars contract forbids declaring it as a *desktop dependency*, not as an ignore — removing a redundant ignore is compatible and coverage is unchanged. - Delete the dead 'src/renderer/**/*.test.ts' entry glob (no matches — renderer has zero test files; all 338 desktop tests live under src/main/__tests__/*.test.ts). - Drop 11 redundant explicit entries knip already auto-detects: desktop preload.ts / renderer/main.tsx / playwright.config.ts / .storybook/main.ts / dev.mjs (vite / playwright / storybook / npm-scripts plugins), and all 6 ui entries (index.ts, icons.tsx, artifact-preview-registry.ts, assistant-stream.ts, maka-uri.ts, smooth-stream.ts) resolved from packages/ui package.json#exports. Non-redundant entries kept verbatim (main.ts, overlay/*, main test glob, e2e specs, storybook preview, stories, browser-observe-act-smoke.mjs, both ui test globs). No broad ignores added — coverage is not weakened. knip --workspace apps/desktop and packages/ui now both exit 0 AND report zero config hints (was: exit 0 with 13 hints).
…esume (R2) The #1223 safe-boundary resume cluster moves out of app-shell.tsx into a new use-shell-resume.ts hook, following the use-shell-connections / use-shell-chat-model house style (options object; state + handler returned; stable identities preserved). Pure move, zero behavior change: the two useState declarations (resumePendingSessionId, resumeParkDescriptionBySession) and the resumeInterruptedSession handler move verbatim; activeId/toastApi/shellCopy/uiLocale are injected as options. app-shell keeps the banner JSX wiring (safeResumeAction=) and the sendWithAttachments guard. resumeParkToastCopy is no longer imported into app-shell (it now lives in the hook). app-shell.tsx 1686 -> 1654 (-32 lines). Contract re-pin (never deletes coverage): runtime-resume-routing-contract.test.ts read the handler-shape assertions (resumeInterruptedSession / resumeLatest(sessionId) / resumeParkToastCopy / no rejectionReasons.join) from app-shell.tsx single-file; they now read use-shell-resume.ts where that logic lives, while the app-shell-specific assertions (sendWithAttachments '/resume' guard, safeResumeAction= wiring) still read app-shell.tsx. use-shell-resume.ts added to renderer-shell-source-helpers sourcePaths (Round B/E precedent) so combined-source contracts see it. Gates: desktop 2740/2740, ui 196/196, typecheck 0, check-dead-css clean, knip desktop+ui exit 0, AUDIT_PORT_BASE=23900 alignment auditor exit 0 (all 10 fixtures clean, real renderer). CDP turn-narrative branch-vs-baseline (real Electron, light+dark 1280) byte-identical (sha256 match) — proven render no-op.
…ore/arch-ui-campaign-0719
…ore/arch-ui-campaign-0719
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One batched campaign PR (goal: 继续 UI/UX 打磨 + 架构洁癖). Three agents: architecture census+map, UI delta audit + fixture implementation, delegable cleanup rounds.
Architecture (map committed: notes/frontend-architecture-map-2026-07-19.md)
UI delta + fixture
Gates (integrated tree, incl. today's external merges)
desktop 2744 · ui 196 · typecheck · check-dead-css · knip ×2 = 0 with 0 hints · alignment auditor all fixtures clean incl. the new one. Implemented by three opus worktree agents; integration verified by maintainer.