fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(headless): record OpenCode prompt provenance accurately - #1781

Closed
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode
Closed

fix(headless): record OpenCode prompt provenance accurately#1781
AlvaroBalbin wants to merge 3 commits into
apache:mainfrom
AlvaroBalbin:issue-1563-fix-headless-record-opencode

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to packages/headless/harbor/opencode_agent.py, .../headless/src/tests/cell-output.test.ts, .../src/tests/fixed-prompt-controller.test.ts, .../headless/src/tests/harbor-adapter.test.ts and a few others that resolves the reported issue without touching anything unrelated.

The repo's own CI runs green on this branch; I ran it on my fork before opening this.

Fixes#1563.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. OpenCode execution identity now comes from the verified toolchain fingerprint, while Maka-owned prompt hashes stay separate. The validation and legacy decoding paths are consistent, and the focused checks pass. I found no issues in the patch.

The branch currently conflicts with main, so the resolved head will need another review.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve (with comments)

The seam choice is right: producer (opencode_agent.py), validator (cell-output.ts), and controller (fixed-prompt-controller.ts) move together, and the resulting identity states the model-visible truth — the prompt is owned by the harness and identified by the pinned toolchain fingerprint. The Python-side prompt-invariance test pins the exact repro from #1563. Approving, with a few non-blocking comments below.

  1. The new schema comment codifies the original falsehood for legacy artifacts.cell-output.ts says of absent systemPromptAuthority: "artifacts written before harness-owned prompts were recorded, which are Maka-injected." That claim is false for exactly the artifacts this PR is about: pre-fix OpenCode cells have no authority, do carry a systemPromptHash, and were not Maka-injected. The else branch in the validator likewise conflates "absent" with 'maka'. Suggest stating the absent semantics as unknown / pre-audit rather than asserting something we know is untrue — truthful provenance is the point of this PR.

  2. The harness-native skip in classifyExecutionIdentityFailure is untested and leaves the cohort hole half-closed. Skipping the prompt-hash comparison for harness-native cells is correct, but (a) nothing pins this deliberate relaxation — a test where the round prompt mismatches and a harness-native cell is still accepted would lock it in; (b) systemPromptToolchain is never compared against an expected fingerprint, so a cell run with the wrong pinned toolchain passes identity checks. Fine as a follow-up, but worth an explicit test + a tracking note now.

  3. 'maka' has no producer. Neither maka_agent.py nor the harbor-cli.ts path emits systemPromptAuthority, so the enum value exists only in the validator. Either emit it from the Maka paths (self-describing, and it is exactly what a future crossed prompt-injection ablation would need), or drop it and make "absent means Maka-owned" the single semantic. The current middle state buys a mutual-exclusion branch that nothing exercises.

  4. or "unpinned" weakens the invariant the validator just established.install() already raises when MAKA_OPENCODE_TOOLCHAIN_FINGERPRINT is missing, so the fallback is unreachable in practice — and if it ever did fire, the literal string "unpinned" would satisfy systemPromptToolchain must pin the harness build. Prefer dropping the fallback and letting the Python side fail loud.

  5. Cell-level promptHash semantics deserve one line of documentation. Keeping _round_prompt_hash() at the cell level is correct — attestedPromptHasheventMatchesResumeIdentity depends on it, and it attests round membership rather than model-visible bytes. But HarborCellOutput.promptHash doesn't say that, so a downstream reader can repeat the #1563 misreading one field level up. A short comment fixes it.

None of these change behavior; 1, 3, and 4 are small deletions/edits, 2 and 5 are test/comment additions.

@AlvaroBalbin

Copy link
Copy Markdown
ContributorAuthor

Closing this. packages/headless was replaced wholesale by the minimal Eval kernel in #2605, so all six files here are gone from main and #1563 is closed as completed.

The provenance point survives in the new design anyway: packages/eval/src/toolchain-verification.ts pins a per-profile toolchain fingerprint, and external-subject.ts refuses to execute a cell whose toolchain was not verified first. That is the identity this patch was trying to record instead of a Maka owned prompt hash, and it also closes the gap from review point 2, where systemPromptToolchain was never compared against an expected fingerprint.

Nothing worth rebasing onto the new kernel. Thanks @Astro-Han for the two reviews.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(headless): record OpenCode prompt provenance accurately

2 participants

@AlvaroBalbin@Astro-Han