Uh oh!
There was an error while loading. Please reload this page.
fix(ci): provision sandbox whenever the cli workspace runs - #1786
Merged
Conversation
packages/cli/src/__tests__/runtime-bootstrap.test.ts executes real
sandboxed shell tools, so the bubblewrap + user-namespace setup is
required whenever the cli workspace is selected through the dependency
closure, not only for direct cli/runtime edits. A storage-only change
(storage -> runtime -> headless -> cli) or a headless change
(headless -> cli) selected the cli tests without provisioning the
sandbox, failing with 'Command sandbox is required but unavailable'.
runtimeSandbox now keys off workspaces.includes('packages/cli') instead
of directWorkspaces; regression test covers both closure paths.Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/cli/src/__tests__/runtime-bootstrap.test.tsexecutes real sandboxed shell tools, but the CI test plan only provisioned the bubblewrap + user-namespace sandbox for directpackages/runtime/packages/cliedits. Changes that reach the cli workspace through the dependency closure (e.g. a storage-only changestorage → runtime → headless → cli, or a headless changeheadless → cli) selected the cli tests without the sandbox, failing withCommand sandbox is required but unavailable.runtimeSandboxnow keys offworkspaces.includes('packages/cli')— the closure result — instead ofdirectWorkspaces. This unblocks the current PR queue (e.g. #1775, #1770, #1742, #1781) which merged latestmainand still hit this.Verification
node --test scripts/ci-test-plan.test.mjs scripts/run-workspace-tests-parallel.test.mjs→ 8/8 passruntimeSandboxfor direct cli, direct runtime, and closure-only storage/headless changes (failed before this change)biome check/biome formatclean on both files