Uh oh!
There was an error while loading. Please reload this page.
test(runtime): trim 60 redundant session-manager tests - #2404
Merged
Conversation
Remove low-value and duplicated coverage from the 23k-line session-manager.test.ts to speed up the runtime test suite: - 11 near-identical copy-paste variants (>=75% similarity, assertions fully covered by the retained test) - 29 trivial tests (<=25 lines, single-point assertions) - 13 similar variants (>=60%, kept the more complete one) - 7 edge variants (50-58%) 320 -> 260 tests, -2,491 lines. Core behavior matrices (continuation, startup recovery, getMessages repair, child/stop) are untouched. Verified with babel AST (0 modified tests, 60/60 exact deletions), esbuild syntax check, tsc build, and node --test 260/260 passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trims 60 low-value/duplicated tests from the 23k-line
packages/runtime/src/__tests__/session-manager.test.tsto speed up the runtime test suite (currently the heaviest test file in the repo).320 → 260 tests (-19%), 23,632 → 21,306 lines (-9.6%)
What was removed
Breakdown by area: getMessages read-model 15, permission/trivial asserts 15, startup recovery 9, next turn 4, markSessionRead 4, durable run ledger 4, hosted 3, child/concurrent 3, others 3.
Not touched
Core behavior matrices are fully retained: continuation claim/serialization, startup recovery, getMessages terminal-fact repair, child/stop session lifecycle, steering/followup queues, ledger/checkpoint durability.
Verification