Uh oh!
There was an error while loading. Please reload this page.
test: trim low-value tests across headless and desktop - #2406
Merged
Conversation
Remove 17 redundant test declarations + 1 meta-test file (-1,112 net lines) after a full-repo low-value test audit: - Delete css-test-helpers.test.ts (600 lines): pure test-infra meta test - the helper is only consumed by other tests (7 contract tests), its correctness is enforced transitively; zero product coverage loss. - Delete 10 near-duplicate variants (>=75% similarity, kept the more complete one): prompt-candidate-loop (4), harbor-cell, ab-run, harness-ab-cli, replay-decision, replay-identity, history-compact. - Parameterize 3 fixed-prompt-controller clusters (8 -> 3 loops): verifier-graded error classes, execution-identity mismatch cases, stop-on-systemic-failure cases. All affected files verified: headless 7 files (328/328 pass), desktop history-compact-artifacts (8/8 pass). Full-repo audit found zero byte-identical duplicates and no skipped/todo dead tests, so this is the safe floor for pure deletion; further cuts trade away guard coverage.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 7, 2026
jackwener added a commit
that referenced
this pull request
Aug 7, 2026
Astro-Han added a commit
that referenced
this pull request
Aug 7, 2026
#2406 deleted the contract tests that imported these helpers; knip on the desktop workspace then failed the typecheck lane for every PR on main.
Astro-Han added a commit
that referenced
this pull request
Aug 7, 2026
#2406 deleted the contract tests that imported these helpers; knip on the desktop workspace then failed the typecheck lane for every PR on main.
2 tasks
jackwener added a commit
that referenced
this pull request
Aug 7, 2026
#2406 trimmed the tests that consumed findBadgeClassNames, findUnreadableBadgeCallSites, cssMediaBody, findTextRoleOffenders, mergeBySelector and assertCustomPropPinnedOnce, which turned them into dead exports the typecheck job's knip gate rejects. Removes the six functions plus the helpers only they consumed (readTsxTree, jsxOpeningTags and the className regexes); every survivor keeps at least one live consumer per the same knip run.
Astro-Han added a commit
that referenced
this pull request
Aug 7, 2026
helper exports. Format residue was cleared in #2410; Knip still failed the required typecheck lane on those unused exports. Remove them and their exclusive private dependency graph, keep what live contracts import.
Astro-Han added a commit
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes low-value tests after a full-repo audit of 954 test files / 9,561 tests. -1,112 net lines, -17 test() declarations, zero product-coverage loss.
Changes
css-test-helpers.test.ts(600 lines): tests a pure test-infra helper (consumed only by 7 contract tests, whose correctness enforces it transitively). Product coverage: 0 loss.max_tokens/tool_step_cap_reached/policy_denied), execution-identity mismatch cases, stop-on-systemic-failure cases — same assertions, table-driven nowAudit findings (why this is the safe floor)
Full-repo scan found:
scripts/*.test.mjs(29 files / 4,170 lines) are CI/release infrastructure — keptRuntime timings: biggest file (ai-sdk-backend, 15k lines) runs in 5s; CI slowness is dominated by
build:testfull tsc compile, not test execution.Verification