Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): drop dead css-test-helpers after #2406 - #2415
Merged
Conversation
helper exports. Format residue was cleared in #2410; Knip still failed the required typecheck lane on those unused exports. Remove them and their exclusive private dependency graph, keep what live contracts import.
Astro-Hanforce-pushed
the
fix/knip-css-test-helpers-dead-exports
branch
from
August 7, 2026 07:49
3cd4303 to
40272baCompareAstro-Han
marked this pull request as ready for review
August 7, 2026 08:00
Uh oh!
There was an error while loading. Please reload this page.
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css-test-helpers.test.tsWhy
#2406 deleted the meta-test that was the last external consumer of:
findBadgeClassNames/findUnreadableBadgeCallSitescssMediaBodyfindTextRoleOffendersmergeBySelectorassertCustomPropPinnedOnce#2410 fixed orphan-semicolon format breakage. #2414 unblocked Knip by turning those exports private. This PR finishes the job: remove the dead functions and their exclusive private dependency graph (
readTsxTree, JSX badge scan, text-role vocabulary scan,mergeByContext/UNCONDITIONAL,parseCssCustomProps, etc.).Live contract tests still import
readAllRendererCss,stripCssComments,parseCssBlocks,splitSelectorList,assertCssRuleDecls, andREPO_ROOT— those stay.Validation
npx knip --workspace apps/desktop(zero findings)node --teston the seven contract tests that import the helpers (17/17 pass)Test plan
Follow-up to #2406 / #2410 / #2414.