Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): treat a blank UA-CH platform as absent in Astryx's mod-key probe - #2418
Merged
Astro-Han merged 1 commit intoAug 8, 2026
Merged
Conversation
GabrielDrapor
marked this pull request as draft
August 7, 2026 09:35
GabrielDraporforce-pushed
the
fix/keyboard-help-modal-styling
branch
from
August 7, 2026 09:47
7a8b2eb to
6c31ee5CompareGabrielDrapor
marked this pull request as ready for review
August 7, 2026 09:57
GabrielDraporforce-pushed
the
fix/keyboard-help-modal-styling
branch
from
August 7, 2026 09:57
6c31ee5 to
d3d1306CompareGabrielDrapor
marked this pull request as draft
August 7, 2026 09:58
GabrielDrapor
marked this pull request as ready for review
August 7, 2026 10:13
GabrielDrapor
marked this pull request as draft
August 7, 2026 10:16
GabrielDraporforce-pushed
the
fix/keyboard-help-modal-styling
branch
from
August 7, 2026 10:21
d3d1306 to
d787267CompareGabrielDrapor
commented
Aug 7, 2026
ContributorAuthor
GabrielDraporforce-pushed
the
fix/keyboard-help-modal-styling
branch
2 times, most recently
from
August 7, 2026 10:57
7f72207 to
150db1eCompareGabrielDraporforce-pushed
the
fix/keyboard-help-modal-styling
branch
from
August 7, 2026 11:09
150db1e to
b9e68c4CompareGabrielDrapor
marked this pull request as ready for review
August 7, 2026 14:56
…key probe (apache#2429) Rewritten-identity Electron bundles (the ad-hoc-signed Maka Dev.app that dev-app-runtime.mjs builds for the TCC workflow) ship navigator.userAgentData EMPTY — platform '' and brands []. Astryx's platform probe (shared by Kbd's ⌘/Ctrl display and useHotkeys' mod binding) prefers UA Client Hints over the deprecated navigator.platform and read the blank as "not Apple": on macOS every mod hotkey listened for Ctrl (⌘+/ did not open the keyboard help; Ctrl+/ did) and every keycap drew Ctrl. Bare `electron .` launches and the release app populate UA-CH correctly and were never affected. The fix rides the repo's dependency-patch mechanism, at the two detection points inside @astryxdesign/core (Kbd.js detectMac, useHotkeys.js isApplePlatform): a blank uaData.platform is treated as absent and falls through to navigator.platform; a non-blank value decides exactly as before. No renderer-global navigator facade — the page's userAgentData object, its prototype identity, toJSON() and getHighEntropyValues() all stay untouched, and non-Apple platforms keep their existing semantics (a blank there already fell back to the correct Ctrl answer). Guards, both proven discriminating: - e2e "blank UA-CH" test reconstructs the broken environment (init script installs platform:'' + brands:[] + navigator.platform MacIntel, then reloads) and asserts the probe lands on ⌘ — red without the patch on every host OS, including Linux CI. - e2e entry-point/layout test pins apache#1689's contract: bare `?` and mod+/ both reach the modal, description/keys resolve to a two-column grid, headings keep caption typography, the + separator renders, keycaps keep their chrome, and the platform's own modifier is displayed. Verified in the real dev bundle via CDP after the patch: uaData still reads '' (no facade), Meta+/ opens the modal, keycaps draw ⌘. Investigating apache#1689 is what surfaced this: the layout regression it reports no longer reproduces on main (pre-cascade-governance era); the e2e above pins that contract so it cannot silently return. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16
GabrielDraporforce-pushed
the
fix/keyboard-help-modal-styling
branch
from
August 7, 2026 15:13
b9e68c4 to
90533baCompare
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Solid. The install flow really does apply the patch (blob hashes match), Kbd and useHotkeys both resolve to the patched dist, and the e2e fails red on any host if either probe is missing. The README scope note is a good touch.
Two nits, neither blocking. The UMD build (dist/astryx.umd.js) keeps two unpatched copies of the probe. Nothing here loads it today, but a CDN consumer would hit the same blank-UA-CH bug; a sentence in the patch README covers that. And Chromium reports 'Unknown' as userAgentData.platform in headless-ish environments. Your guard treats only blank as absent, so macOS still lands on the wrong branch there. Treating 'Unknown' as absent too is free and the Linux fallback stays as is.
Merging.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#2429. Related: #1689 (investigation origin — its reported layout regression no longer reproduces on main; the new e2e pins that contract).
What changed since the last review
All five findings addressed by rebuilding the fix:
Kbd.jsdetectMac,useHotkeys.jsisApplePlatform): a blankuaData.platformis treated as absent and falls through tonavigator.platform. The page'suserAgentDataobject, its prototype identity,toJSON()andgetHighEntropyValues()stay untouched — verified live:platformstill reads""in the dev bundle, keycaps draw ⌘.platform:''+brands:[]+navigator.platform: 'MacIntel', then reloads) and drives the REAL patched probe end to end. Proven discriminating: red without the patch, green with it — on every host OS including Linux CI, because the fake Mac platform makes the fall-through observable as a ⌘ keycap.?andmod+/entry points, two-columngrid-template-columns, heading caption typography (12px/600), the+separator, keycap chrome, platform-correct modifier, and close-toggle.Root cause (unchanged)
Rewritten-identity Electron bundles (the ad-hoc-signed
Maka Dev.appfromdev-app-runtime.mjs's TCC workflow) shipnavigator.userAgentDataempty. Astryx's probe prefers UA-CH overnavigator.platformand reads the blank as "not Apple" — on macOSmodhotkeys bound Ctrl (⌘+/ dead) and keycaps drew Ctrl. Bareelectron .and releaseMaka.apppopulate UA-CH correctly (release user-verified on 0.1.6).Patch governance
patches/README.mdgains the required section: reason, scope (only the blank-value branch), and deletion condition (the guard e2e passing unpatched means upstream learned to distrust the blank).Tests
uaData.platformstill"", Meta+/ opens, keycaps ⌘Co-Authored-By: Claude noreply@anthropic.com
https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16