Uh oh!
There was an error while loading. Please reload this page.
test(windows): validate crash recovery boundaries - #2475
Merged
Conversation
37 tasks
Astro-Han
commented
Aug 8, 2026
Contributor
Thanks — this is a useful improvement to the Windows crash-recovery coverage. Reusing the existing process-tree terminator, waiting for the Runtime child A few non-blocking P3 follow-ups:
These do not need to block this PR. The current implementation and CI evidence look sufficient to merge. Thanks! |
Astro-Han
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows evidence
Validation
npm --workspace @maka/runtime run buildnode --test --test-reporter=spec packages/runtime/dist/__tests__/runtime-continuation-crash.test.jsnode --test --test-reporter=spec packages/runtime/dist/__tests__/runtime-resume-crash.test.jsnpm --workspace @maka/storage run buildnpm run windows:inventorynode --test scripts/windows-test-inventory.test.mjsgit diff --checkAddresses the Windows crash/recovery harness item in #2142.