Uh oh!
There was an error while loading. Please reload this page.
test(runtime-host): validate Windows crash recovery - #2483
Conversation
jackwener
commented
Aug 8, 2026
Review decisionProblem real: Windows could not exercise Host crash recovery; fixture held SQLite handles across lease release (EBUSY), and SIGTERM-based graceful stop is not a portable Host teardown contract. Fix correct:
Landing via rebased PR after inventory conflict resolution. |
jackwener
commented
Aug 8, 2026
Landing via rebased maintainer PR. Thanks @liugddx! |
Astro-Han
commented
Aug 8, 2026
Thanks — the recovery harness changes look well scoped. Keeping the real crash path as The recovery scenario itself is valuable: it verifies recovery before successor readiness, The remaining work is integration with current Please rebase and regenerate the Windows inventory The PR currently conflicts only in Please rebase and run P3 — Add focused Windows CI evidence for the new contract The existing Windows baseline builds the repository and runs inventory, scripts, smoke, and Storage tests, but it does not execute Runtime Host tests. The target recovery case currently runs automatically only on Linux; the Windows 3/3 result in the PR description is local evidence. A narrow Windows step for the single recovery case would protect the new platform contract without running the full Runtime Host suite, for example: node.exe--test --test-name-pattern="a killed Host is recovered exactly once" packages/runtime-host/dist/__tests__/execution-host-queue.test.jsThis can remain part of the current non-blocking Windows baseline. It is a coverage improvement rather than a reason to redesign the harness. After the rebase, regenerated inventory, and fresh CI run, this should be ready for another quick review. Thanks! |
Summary
Validation
npm --workspace @maka/runtime-host run buildnpm --workspace @maka/runtime-host run typechecknode --test packages/runtime-host/dist/__tests__/execution-host-queue.test.js(9/9 passed)npm run windows:inventorygit diff --checkThe full runtime-host suite still exposes pre-existing Windows baseline failures outside this change, primarily SQLite file removal and live-root rename semantics tracked by #2142.
Part of #2142