') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); chore: finish test cleanup by me2seeks · Pull Request #2702 · apache/maka · GitHub
Skip to content

chore: finish test cleanup - #2702

Closed
me2seeks wants to merge 1 commit into
apache:mainfrom
me2seeks:chore/restore-main-format
Closed

chore: finish test cleanup#2702
me2seeks wants to merge 1 commit into
apache:mainfrom
me2seeks:chore/restore-main-format

Conversation

@me2seeks

@me2seeksme2seeks commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • apply the repository formatter after the recent test cleanup
  • remove the session-list render helper left without any consumers
  • restore the full static-analysis path on current main

This is limited to formatter output in test files and the now-unused test helper. It does not change runtime behavior or test assertions.

Testing

  • npm run format:check
  • npm run lint
  • npx knip --workspace apps/desktop
  • npm run build:test
  • npm run typecheck
中文对照

摘要

  • 在近期测试清理后应用仓库格式化工具
  • 删除已经没有调用方的 session-list 渲染测试 helper
  • 恢复当前主线的完整静态检查链

本 PR 仅包含测试文件的格式化结果和一个已无调用方的测试 helper，不修改运行时行为或测试断言。

测试

  • npm run format:check
  • npm run lint
  • npx knip --workspace apps/desktop
  • npm run build:test
  • npm run typecheck

@me2seeks
me2seeksforce-pushed the chore/restore-main-format branch from 5e40b54 to f743e5eCompareAugust 11, 2026 13:22
@me2seeksme2seeks changed the title chore: restore formatting after test cleanupchore: finish test cleanupAug 11, 2026
@MoonOldMoonOld mentioned this pull request Aug 11, 2026
Closed
4 tasks
@MoonOld

MoonOld commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

The E2E failure here is the separate Desktop fixture regression tracked in #2705: #2700 removed legacy Runtime Policy migration while the Playwright fixture still seeded legacy files. I opened #2706 with the fixture-only authority seed fix; this PR remains the formatter/Knip baseline fix.

@GabrielDraporGabrielDrapor mentioned this pull request Aug 12, 2026
Closed
@me2seeks

me2seeks commented Aug 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Superseded by #2712, which includes the formatter and orphan-helper cleanup along with the remaining CI hygiene fixes. Closing this duplicate; thanks for carrying the baseline fix through.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@me2seeks@MoonOld