') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); chore: retire the single-record bundled Skill provenance schema by rbalachandar · Pull Request #3738 · apache/maka · GitHub
Skip to content

chore: retire the single-record bundled Skill provenance schema - #3738

Merged
Astro-Han merged 1 commit into
apache:mainfrom
rbalachandar:chore/retire-bundled-skill-provenance
Aug 25, 2026
Merged

chore: retire the single-record bundled Skill provenance schema#3738
Astro-Han merged 1 commit into
apache:mainfrom
rbalachandar:chore/retire-bundled-skill-provenance

Conversation

@rbalachandar

@rbalachandarrbalachandar commented Aug 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

packages/runtime/resources/bundled-skills/provenance.json held one record and had no consumers: scripts/gen-bundled-skill-catalog.mjs reads only <id>/SKILL.md, and the sole reference in the tree was docs/code-origin-audit.md. The schema was built for the batch that #2695 resolved — 29 Skills went, one stayed.

This PR deletes the file and moves the computer-use Skill's origin, AI-assistance, and review facts into the "Bundled Skills" section of docs/code-origin-audit.md, which already had to be touched to remove the provenance.json reference.

The issue's two constraints are preserved:

  • The record stays out of SKILL.md, so provenance edits never change installed Skill content hashes — the property the deleted file existed to hold.
  • It does not touch docs/computer-use-provenance.md, which registers third-party material; this Skill is origin: independently-authored.

Every fact is carried over verbatim from the deleted JSON (author Haoqing Wang / @hqhq1025, OpenAI Codex drafting assistance, inputs list, introduction via #2147 at 2fb83e20, contributor confirmation 2026-08-11, independent review in #2676 at 3c7683b9 on 2026-08-12 with its scope caveat), anchored to fixed commits so the historical audit report is not turned into mutable living state.

Fixes#3424

Verification

  • npm run generate:bundled-skills -- --check — catalog unaffected (the generator never read the JSON)
  • npm run format:check, npm run typecheck, npm run check:asf-headers
  • Repo-wide search confirms no remaining references to provenance.json
  • Not run: npm run lint, npm run build, knip — no code changed; CI covers them

Review focus

One tradeoff worth flagging: docs/code-origin-audit.md is a dated evidence report. Folding the record in means any future bundled-Skill provenance update edits a historical document; if more Skills are bundled later, a dedicated provenance home may be worth revisiting.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: opencode explored the repository, drafted both the doc change and this description, and proposed the record's new home (selected by the human contributor of record, who reviewed every fact against the deleted JSON before submitting). The commit carries a Generated-by: opencode trailer.

Checklist

  • Tests cover the change and fail without it — not applicable: resource-file deletion plus documentation; nothing testable changed (catalog generator check confirms behavior is unchanged)
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • No

@rbalachandar
chore: retire single-record bundled Skill provenance schema
4854b5b
provenance.json held one record and had no consumers; the bundled Skill
catalog reads only <id>/SKILL.md and the sole tree reference was
docs/code-origin-audit.md. The computer-use Skill's origin, AI-assistance,
and review facts now live in the audit's Bundled Skills section — outside
SKILL.md so provenance edits never change installed Skill content hashes.
Closesapache#3424
Generated-by: opencode
@rbalachandar
rbalachandarforce-pushed the chore/retire-bundled-skill-provenance branch from dadd63a to 4854b5bCompareAugust 24, 2026 20:35
Astro-Han
Astro-Han reviewed Aug 25, 2026
View reviewed changes

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found no blocking issues.

The retirement removes a retired bundled Skill provenance schema (schemaVersion 1 / unresolvedGroups metadata) while preserving all substantive facts in code-origin-audit. No hidden consumers remain (generator still scans SKILL.md directories, SHA unchanged). Document hygiene is maintained and checks are green.

No P0-P3.

简体中文该头未发现阻断。

Astro-Han
Astro-Han approved these changes Aug 25, 2026
View reviewed changes

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 4854b5b, no P0-P3, provenance correctly retired.

@Astro-Han
Astro-Han merged commit 622abb4 into apache:mainAug 25, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Astro-HanAstro-HanAstro-Han approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: retire the single-record bundled Skill provenance schema

2 participants

@rbalachandar@Astro-Han