Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): skills header control alignment + models list radius language (round 10) - #666
Merged
Merged
Conversation
…nguage (round 10) Maintainer reports, both CDP-measured: - 技能 header: search field (32px, radius 8) and 添加 CTA (36px, radius 6) sat in one row misaligned. Both now 36px / radius-control. Measured 36/36 + 6px/6px. - 模型 connection list: interactive row fills (provider trigger hover, selected connection) were square full-bleed bands in an app whose every other row surface (sidebar nav, session list) rounds its fill. Rows now carry radius-control; the seamless-list shell (deliberate no-card decision) is unchanged. Measured 0→6px. Desktop 2285/2285 (exit-code gated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two maintainer reports, both root-caused with CDP measurement:
1. 技能 header misalignment — the 搜索技能 field rendered 32px tall with radius-surface (8px) while the adjacent 添加 primary is 36px with radius-control (6px): two heights and two radius families in one row. The search field now matches the control recipe: 36px + radius-control. Measured after: 36/36, 6px/6px.
2. 模型连接 square corners — the connection list's interactive fills (provider hover band, selected-connection band) were square edge-to-edge bands, breaking the app's radius language where every other row surface (sidebar nav rows, session list rows) rounds its fill. Row fills now carry radius-control (measured 0→6px); the deliberate seamless-list shell (no card — an earlier decision to de-weight the page) is preserved.
Desktop 2285/2285 gated on exit code; check-dead-css clean.