fix(desktop): 模型连接 rows speak the same row language as the catalog below by jackwener · Pull Request #675 · apache/maka

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener · 2026-07-09T13:01:39Z

Maintainer report: the connection sub-rows under 模型连接 clash with the well-formed 模型供应商 rows below — same page, two row implementations.

Root cause: the expanded provider panel painted its own full-bleed 2% wash + hairline from x=0, an edge-to-edge band running under the logo column. No other list surface in the app does this — sidebar rows, session rows, catalog rows all carry state on rounded, inset row fills.

Fix: panel chrome removed; hover/selected state now lives on the rounded row fills (radius from #666), inset mx-2 with pl-10 so the text column stays at the same 48px absolute position under the provider name. All spacing on the 4px ruler — the spacing-converge contract correctly rejected the first pl-[42px] attempt, which is the governance system working as designed.

On the maintainer's broader point (shared solutions, per-site implementations): the audit keeps converging these one recipe at a time with contracts pinning each convergence; the standing NEXT item to extract shared PageShell/row primitives is recorded in the audit plan. CDP capture verified; desktop 2291/2291 exit-code gated.

The expanded provider panel painted a full-bleed 2% wash + top border from x=0 — an edge-to-edge band running under the logo column that read as a different component from the 模型供应商 rows below (maintainer: '共用的解决方案却每处单独实现'). The panel is transparent now; hover / selected state lives on the rounded row fills, inset from the edges (mx-2 + pl-10 keeps text at the same 48px absolute column), exactly the sidebar/session-row recipe. Spacing stays on the 4px ruler per the spacing-converge contract (which correctly rejected my first pl-[42px] attempt). Desktop 2291/2291.

…rgence round 2) (#686) * refactor(ui): adopt the Item primitive for state-fill list rows (round 2) Extend primitives/item.tsx with a `selected` prop (data-selected → --state-selected-bg, the governed 6.5% foreground-alpha token) and an `interactive` gate so inert geometry-only rows can borrow Item's media/content/actions layout without a hover fill. Item already speaks hover 4% / pressed 8% via Base UI useRender + render-prop composition. Migrations: - models 连接行 (enabledConnRow): data-default → Item `selected`; retire the bespoke [data-default] fill rule in models.css. #675 mx-2/pl-10/pr-6 geometry preserved. - daily-review archive rows: UiButton variant=quiet → Item render=<button> with `selected` for the active archive; ItemContent stacks title over the tabular-nums meta line. daily-review.css keeps only geometry + the selected-border accent. - providerCatalogRow: already on Item (round 1 groundwork) — no change needed; its remaining CSS is pinned list-separator/logo-plate geometry. Deferred/skipped (disproportionate contract risk, no state-fill to converge — noted for a later round): - enabledProviderTrigger: a Base UI AccordionTrigger header, not a list row; its hover already uses --state-hover-bg. - settingsOsPermissionRow: static grid row w/ status ::before stripe, pinned by permissions-unified-card (grid/divider/div-actions) — Item's flex model conflicts, zero interactive fill to fold. - daily-review session rows: composite (hover on the <li> container + non-interactive preview sibling outside the button) — not a single state-fill row. - maka-skill-library-row: bespoke 3-col grid + 38px icon tile, hover on the parent <li>, pinned by skills.test.ts; interactive={false} support added so a future round can adopt without behavior change. - sidebar .maka-list-row/.maka-nav-row: untouched by design (densest pins). Verify: desktop 2291/2291, ui 46/46, check-dead-css clean, audit-alignment clean (no new findings on any fixture). * docs: mark convergence map round 2 (Item rows) shipped with deferrals

jackwener merged commit 24cd26a into mainJul 9, 2026
3 checks passed

jackwener deleted the fix/models-connection-rows branch July 9, 2026 13:01

jackwener mentioned this pull request Jul 9, 2026
refactor(ui): Item primitive adoption for state-fill list rows (convergence round 2) #686
Merged