Uh oh!
There was an error while loading. Please reload this page.
refactor(ui): chip convergence — one tone table, five recipes retired (convergence round 1) - #681
Merged
Merged
Conversation
…primitive (round 1) Converge status labels onto the squared Chip primitive (tone→alpha authority in packages/ui/src/primitives/chip.tsx), retiring bespoke CSS label recipes. Primitive-free CSS labels → Chip (packages/ui): - skills-panel: maka-skill-library-status-label + state_error runtime label render Chip size="sm"; tone derived from data-status via skillStatusChipTone (metadata_error/local_modified→warning, managed→info, bundled/本地→neutral). - plan-reminder-panel: maka-plan-run-status → Chip (triggered→info, blocked→warning, failed→destructive). - daily-review-panel: maka-daily-review-archive-status → Chip (ok→success, failed/no_model→destructive, else neutral). Orphaned tone CSS deleted; check-dead-css stays clean. Settings labels → Chip: - settingsAuthActionPill: non-interactive guidance label → Chip (AccountAuthTone maps 1:1 to variants); the real 测试凭据 button stays a Button; preview-kind dashed border kept. - settingsBotStatusPill: added a `dot?` prop to Chip (leading 6px currentColor round dot at 70% alpha) and migrated the hero "● 待配置" pill. - providerCatalogBadge.is-state: gated-provider state label → Chip (unavailable→info, experimental→warning). Category / OAuth badges unchanged. Contracts re-pinned to the new form (coverage preserved, never deleted): - chip-converge-contract: file list GAINS the 5 new call sites; pins the dot prop + retired settingsBotStatusPillDot CSS. - skills.test / bot-settings-ui-contract: label pins updated to the Chip render. Status color stays exception-only; spacing on the 4px ruler.
Uh oh!
There was an error while loading. Please reload this page.
jackwener added a commit
that referenced
this pull request
Jul 9, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 1 of the convergence map (notes/ui-convergence-map-2026-07-09.md): the status-chip family had the highest duplication — 5+ hand-rolled CSS recipes each re-declaring the tone→alpha table that primitives/chip.tsx already owns.
Migrated onto
Chip:dotprop (6px currentColor dot), settingsBotStatusPill retiredOld CSS deleted; chip-converge contract EXTENDED to pin all new call sites + the dot prop; skills/bot contracts re-pinned to the Chip form. Minor intended normalization: legacy alphas snap to Chip's pinned values (warning /14→/18) — Chip is the authority.
Verified in worktree: desktop 2291/2291 + ui 46/46 (exit-code gated), dead-css clean, alignment auditor clean, CDP captures across all five touched surfaces. Implemented by an opus worktree agent to the convergence-map spec.