Uh oh!
There was an error while loading. Please reload this page.
feat(providers): centralize provider registry - #866
Merged
Conversation
Astro-Han
marked this pull request as ready for review
July 13, 2026 11:57
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #860 requires one generic provider extension path before the remaining provider workstreams can proceed. The current implementation still distributes provider behavior across hand-maintained lists and provider-specific runtime branches, which makes each new provider require parallel edits.
This change completes the Phase 2 registry foundation while preserving existing connections and behavior.
Refs #860
Scope
This PR only implements Phase 2.
It does not add Phase 3–5 providers, change first-run onboarding, or redesign existing OAuth account flows. Onboarding continues to use its current list until Phase 6 consumes the shared recommended set.
Verification
npm run typechecknpm testnpm --workspace @maka/desktop run e2e— 13 passednpm run check:stale— dist is freshNo visual evidence is included because this is a behavior-preserving registry migration with no intended UI or interaction changes. The existing provider Settings E2E flow verifies the affected catalog path.
Impact
Existing persisted provider ids, provider ordering, defaults, runtime routing, discovery behavior, and visible Settings behavior remain compatible. No data migration, documentation update, or release-note entry is required.
Reviewer notes
PROVIDER_DEFAULTSremains as a compatibility alias to the same registry object; it does not create a second source of state. The two commits are independently revertible: the first establishes and migrates the shared registry/runtime seam, and the second moves Settings catalog recommendations and placement onto that seam.Ready for review
Verificationexplains why it is not applicable