Uh oh!
There was an error while loading. Please reload this page.
feat(desktop): route first run to provider catalog - #875
Merged
Conversation
Astro-Hanforce-pushed
the
feat/first-run-provider-catalog
branch
from
July 13, 2026 13:41
d7d05cc to
31ca4daCompareAstro-Hanforce-pushed
the
feat/first-run-provider-catalog
branch
from
July 13, 2026 13:43
31ca4da to
ae083f9CompareAstro-Han
marked this pull request as ready for review
July 13, 2026 13:48
Uh oh!
There was an error while loading. Please reload this page.
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RECOMMENDED_PROVIDER_TYPESset instead of an onboarding-specific list.Browse all providersaction that opens the existing Settings provider catalog directly.Why
Phase 6 of #860 requires first-run onboarding to stop owning a parallel provider list and reuse the shared provider catalog established by #863 and #866. This keeps provider recommendation and catalog ownership in the registry while preserving the existing connection-management flow.
Refs #860
Scope
This PR implements Phase 6 only. It does not add providers, change provider configuration behavior, redesign connection management, or implement Phase 7 cleanup and conformance work.
Verification
npm run typechecknpm --workspace @maka/desktop test— 2,399 passednpm --workspace @maka/desktop run e2e— 13 passednode --test apps/desktop/dist/main/__tests__/icon-governance-contract.test.js— 4 passednpm run check:stale— dist is freshmainrebase and review-finding fix.No standalone visual artifact is included. The user-visible change is a navigation action rather than a static appearance change; the deterministic first-run Playwright journey verifies registry-owned recommendation order, direct entry into the shared searchable Settings catalog, and one-shot navigation behavior after returning to model connections.
Brand-asset audit: this PR adds or edits no SVG or provider-brand asset. First-run renders the existing shared
ProviderLogo→ProviderBrandMarkpath. The recommended marks are consumed unchanged from the existing vendor set sourced fromlobehub/lobe-icons, npm@lobehub/icons-static-svg@1.91.0, git commite4302041fbb3039608d25f9f618bd462783b875e, MIT license:icons/siliconcloud.svg,icons/claude-color.svg,icons/openai.svg,icons/gemini-color.svg,icons/moonshot.svg,icons/deepseek-color.svg, andicons/ollama.svg. Plan aliases reuse their provider mark; no plan-specific logo is created.Impact
Fresh workspaces now show the registry-owned recommended provider set and can open the full provider catalog directly. Existing persisted provider ids, provider configuration, connection management, runtime behavior, credentials, and model selection are unchanged. No migration, documentation update, or release-note entry is required.
Reviewer notes
Review the ownership boundary: onboarding consumes
RECOMMENDED_PROVIDER_TYPES, the new action initializes the existingProvidersPanelcatalog, andSettingsSurfaceconsumes that one-shot intent after the first loaded model-page mount. First-run must continue using the shared provider brand-mark path; this PR must not introduce provider SVG assets.Ready for review
Verificationexplains why it is not applicable