Skip to content

HDDS-3741. Reload old OM state if Install Snapshot from Leader fails - #1129

Merged
hanishakoneru merged 9 commits into
apache:masterfrom
hanishakoneru:HDDS-3741
Jul 17, 2020
Merged

HDDS-3741. Reload old OM state if Install Snapshot from Leader fails#1129
hanishakoneru merged 9 commits into
apache:masterfrom
hanishakoneru:HDDS-3741

Conversation

@hanishakoneru

@hanishakoneruhanishakoneru commented Jun 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Follower OM issues a pause on its services before installing new checkpoint from Leader OM (Install Snapshot). If this installation fails for some reason, the OM stays in paused state. It should be unpaused and the old state should be reloaded.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3741

How was this patch tested?

Unit tests added.

arp7
arp7 reviewed Jun 29, 2020
View reviewed changes
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated
arp7
arp7 reviewed Jun 29, 2020
View reviewed changes
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated

@arp7arp7Jun 29, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this unpause, we already do a reload and unpause below.

Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated
@hanishakoneru

hanishakoneru commented Jun 30, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks @arp7 for the review. Addressed your review comments.

arp7
arp7 approved these changes Jul 7, 2020
View reviewed changes

@arp7arp7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Are existing tests covering the modified code paths?

@hanishakoneru
hanishakoneruforce-pushed the HDDS-3741 branch 2 times, most recently from 60a432d to e45b5f8CompareJuly 10, 2020 23:07
arp7
arp7 reviewed Jul 11, 2020
View reviewed changes
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated
arp7
arp7 reviewed Jul 11, 2020
View reviewed changes
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java Outdated

@arp7arp7Jul 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use ExitManager here?

arp7
arp7 reviewed Jul 16, 2020
View reviewed changes

@arp7arp7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing changes to OzoneManager.java.

Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java Outdated
Comment thread...one-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java Outdated
Comment thread...-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OzoneManagerSnapshotProvider.java Outdated
arp7
arp7 reviewed Jul 16, 2020
View reviewed changes
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated

@arp7arp7Jul 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On successful restart we should clear any old backups.

@arp7arp7Jul 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this in a followup jira. Ok to commit this one.

@hanishakoneru
hanishakoneru merged commit 3571d7e into apache:masterJul 17, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'master' into HDDS-3869
af8b4d4
* master:
HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
HDDS-3855. Add upgrade smoketest (apache#1142)
HDDS-3964. Ratis config key mismatch (apache#1204)
HDDS-3612. Allow mounting bucket under other volume (apache#1104)
HDDS-3926. OM Token Identifier table should use in-house serialization. (apache#1182)
HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK (apache#1164)
HDDS-3966. Disable flaky TestOMRatisSnapshots
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'HDDS-3869' into switch-to-new-interface
cf6e0c4
* HDDS-3869:
HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'master' into HDDS-3976
18f6a18
* master:
HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
errose28 pushed a commit to errose28/ozone that referenced this pull request Jul 21, 2020
@hanishakoneru@errose28
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (a…
3f7b4eb
…pache#1129)
errose28 added a commit to errose28/ozone that referenced this pull request Jul 21, 2020
@errose28
Merge branch 'add-deleted-block-table' into HDDS-3869
2fa068b
* add-deleted-block-table: (63 commits)
Make block iterator tests use deleted blocks table, and remove the now unused #deleted#
Replace uses of #deleted# key prefix with access to new deleted blocks table
Add deleted blocks table to base level DB wrappers
Have block deleting service test look for #deleted# keys in metadata table
Move block delete to correct table and remove debugging print statement
Import schema version when importing container data from export
HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
Move new key value block iterator implementation and tests to new interface
Fix checkstyle violations
HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
Update comments
Add comments on added helper method
Remove seekToLast() from iterator interface, implementation, and tests
Add more robust unit test with alternating key matches
All unit tests pass after allowing keys with deleted and deleting prefixes to be made
HDDS-3855. Add upgrade smoketest (apache#1142)
HDDS-3964. Ratis config key mismatch (apache#1204)
...
ChenSammi pushed a commit that referenced this pull request Jul 22, 2020
@hanishakoneru@ChenSammi
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (#…
d92bcba
…1129)
(cherry picked from commit 3571d7e)
timmylicheng pushed a commit that referenced this pull request Aug 6, 2020
@hanishakoneru@timmylicheng
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (#…
db3cef0
…1129)
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
@hanishakoneru@rakeshadr
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (a…
3b930ab
…pache#1129)
@hanishakoneru
hanishakoneru deleted the HDDS-3741 branch December 1, 2020 21:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arp7arp7arp7 approved these changes
@bharatviswa504bharatviswa504Awaiting requested review from bharatviswa504

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanishakoneru@arp7@ChenSammi