Skip to content

HDDS-3926. OM Token Identifier table should use in-house serialization. - #1182

Merged
xiaoyuyao merged 4 commits into
apache:masterfrom
prashantpogde:HDDS-3926
Jul 16, 2020
Merged

HDDS-3926. OM Token Identifier table should use in-house serialization.#1182
xiaoyuyao merged 4 commits into
apache:masterfrom
prashantpogde:HDDS-3926

Conversation

@prashantpogde

@prashantpogdeprashantpogde commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Ozone Manager Token Identifier table should use in-house serialization rather than rely on proto serialization for key.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3926

How was this patch tested?

CleanBuild and Integration Tests

xiaoyuyao
xiaoyuyao reviewed Jul 9, 2020
View reviewed changes
Comment threadhadoop-hdds/interface-client/src/main/proto/proto.lock Outdated
adoroszlai
adoroszlai previously requested changes Jul 10, 2020
View reviewed changes

@adoroszlaiadoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prashantpogde for working on this.

Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java Outdated
Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java Outdated
Comment thread...ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/codec/TokenIdentifierCodec.java Outdated
Comment thread...ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/codec/TokenIdentifierCodec.java Outdated
Comment threadhadoop-hdds/interface-client/src/main/proto/proto.lock Outdated
@adoroszlai
adoroszlai dismissed their stale reviewJuly 11, 2020 05:25

Thanks @prashantpogde for updating the patch.

xiaoyuyao
xiaoyuyao reviewed Jul 13, 2020
View reviewed changes

@xiaoyuyaoxiaoyuyao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, a few questions added inline...

@xiaoyuyao

xiaoyuyao commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

+1 pending CI.

@avijayanhwx

avijayanhwx commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

Please don't merge this since we are testing out upgrade paths.

@avijayanhwx

avijayanhwx commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

/pending

github-actions[bot]
github-actionsBot requested changes Jul 15, 2020
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

/pending

xiaoyuyao
xiaoyuyao reviewed Jul 16, 2020
View reviewed changes

@xiaoyuyaoxiaoyuyao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prashantpogde for the update. Just one more issue wrt. to potential upgrade issue brought up by @avijayanhwx in offline discussion.

@prashantpogde

prashantpogde commented Jul 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Made the changes as suggested by @xiaoyuyao .

@xiaoyuyao
xiaoyuyao merged commit 7e37f7b into apache:masterJul 16, 2020
xiaoyuyao pushed a commit that referenced this pull request Jul 16, 2020
@prashantpogde@xiaoyuyao
HDDS-3926. OM Token Identifier table should use in-house serializatio…
ca9b368
…n. (#1182)
(cherry picked from commit 7e37f7b)
errose28 added a commit to errose28/ozone that referenced this pull request Jul 17, 2020
@errose28
Merge branch 'master' into HDDS-3976
3ef5841
* master:
HDDS-3855. Add upgrade smoketest (apache#1142)
HDDS-3964. Ratis config key mismatch (apache#1204)
HDDS-3612. Allow mounting bucket under other volume (apache#1104)
HDDS-3926. OM Token Identifier table should use in-house serialization. (apache#1182)
HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK (apache#1164)
errose28 added a commit to errose28/ozone that referenced this pull request Jul 17, 2020
@errose28
Merge remote-tracking branch 'upstream/master' into switch-to-new-int…
548da86
…erface
* upstream/master:
HDDS-3855. Add upgrade smoketest (apache#1142)
HDDS-3964. Ratis config key mismatch (apache#1204)
HDDS-3612. Allow mounting bucket under other volume (apache#1104)
HDDS-3926. OM Token Identifier table should use in-house serialization. (apache#1182)
HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK (apache#1164)
HDDS-3966. Disable flaky TestOMRatisSnapshots
errose28 added a commit to errose28/ozone that referenced this pull request Jul 20, 2020
@errose28
Merge branch 'master' into HDDS-3869
af8b4d4
* master:
HDDS-3984. Support filter and search the columns in recon UI (apache#1218)
HDDS-3806. Support recognize aws v2 Authorization header. (apache#1098)
HDDS-3955. Unable to list intermediate paths on keys created using S3G. (apache#1196)
HDDS-3741. Reload old OM state if Install Snapshot from Leader fails (apache#1129)
HDDS-3965. SCM failed to start up for duplicated pipeline detected. (apache#1210)
HDDS-3855. Add upgrade smoketest (apache#1142)
HDDS-3964. Ratis config key mismatch (apache#1204)
HDDS-3612. Allow mounting bucket under other volume (apache#1104)
HDDS-3926. OM Token Identifier table should use in-house serialization. (apache#1182)
HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK (apache#1164)
HDDS-3966. Disable flaky TestOMRatisSnapshots
errose28 pushed a commit to errose28/ozone that referenced this pull request Jul 21, 2020
@prashantpogde@errose28
HDDS-3926. OM Token Identifier table should use in-house serializatio…
8a9e833
…n. (apache#1182)
timmylicheng pushed a commit that referenced this pull request Aug 6, 2020
@prashantpogde@timmylicheng
HDDS-3926. OM Token Identifier table should use in-house serializatio…
e7cac9a
…n. (#1182)
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
@prashantpogde@rakeshadr
HDDS-3926. OM Token Identifier table should use in-house serializatio…
e1a687f
…n. (apache#1182)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adoroszlaiadoroszlaiadoroszlai left review comments
@xiaoyuyaoxiaoyuyaoxiaoyuyao left review comments
@avijayanhwxavijayanhwxavijayanhwx left review comments
@ChenSammiChenSammiChenSammi left review comments
@github-actionsgithub-actions[bot]github-actions[bot] requested changes

Assignees

No one assigned

Labels

pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@prashantpogde@xiaoyuyao@avijayanhwx@adoroszlai@ChenSammi