Skip to content

HDDS-4079. Create ZH translation of Containers.md in doc. - #1539

Merged
cku328 merged 1 commit into
apache:masterfrom
yuyang733:HDDS-4079
Nov 15, 2020
Merged

HDDS-4079. Create ZH translation of Containers.md in doc.#1539
cku328 merged 1 commit into
apache:masterfrom
yuyang733:HDDS-4079

Conversation

@yuyang733

@yuyang733yuyang733 commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Create ZH translation of Containers.md in doc.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4079

@maobaolong

maobaolong commented Nov 10, 2020

Copy link
Copy Markdown
Member

@yuyang733 Thanks for this document.

Please insert a space around a English word, something like this

Container是Ozone/HDDS的基本复制单元 -> Container 是 Ozone/HDDS 的基本复制单元

@maobaolong
maobaolong self-requested a review November 10, 2020 04:47
cku328
cku328 requested changes Nov 10, 2020
View reviewed changes

@cku328cku328 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuyang733 for working on this.

I think we should ensure that some of the words are consistent with other existing documents.
Container -> 容器 ,etc.

Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
@cku328cku328 added the documentation Improvements or additions to documentation label Nov 10, 2020
@yuyang733

yuyang733 commented Nov 10, 2020

Copy link
Copy Markdown
ContributorAuthor

@yuyang733 Thanks for this document.

Please insert a space around a English word, something like this

Container是Ozone/HDDS的基本复制单元 -> Container 是 Ozone/HDDS 的基本复制单元

done

@yuyang733

yuyang733 commented Nov 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks @yuyang733 for working on this.

I think we should ensure that some of the words are consistent with other existing documents.
Container -> 容器 ,etc.

done

@yuyang733
yuyang733force-pushed the HDDS-4079 branch 3 times, most recently from 0b10b81 to f506fd6CompareNovember 12, 2020 04:27
cku328
cku328 requested changes Nov 12, 2020
View reviewed changes

@cku328cku328 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuyang733 for updating the patch.
Just some minor comments base on existing other docs.

Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
@yuyang733
yuyang733force-pushed the HDDS-4079 branch 2 times, most recently from 28de631 to 1a98da1CompareNovember 12, 2020 12:20
cku328
cku328 reviewed Nov 12, 2020
View reviewed changes
Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
cku328
cku328 reviewed Nov 12, 2020
View reviewed changes
Comment threadhadoop-hdds/docs/content/concept/Containers.zh.md Outdated
cku328
cku328 approved these changes Nov 14, 2020
View reviewed changes

@cku328cku328 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 for the latest patch.
If @maobaolong or others have no comments, I will merge this by tomorrow.

@cku328
cku328 merged commit 45e30d6 into apache:masterNov 15, 2020
@maobaolong

maobaolong commented Nov 16, 2020

Copy link
Copy Markdown
Member

@cku328 Thanks, it looks good to me.

errose28 added a commit to errose28/ozone that referenced this pull request Nov 18, 2020
@errose28
Merge branch 'master' into HDDS-4123
895219c
* master: (53 commits)
HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585)
HDDS-4442. Disable the location information of audit logger to reduce overhead (apache#1567)
HDDS-4441. Add metrics for ACL related operations.(Addendum for HA). (apache#1584)
HDDS-4081. Create ZH translation of StorageContainerManager.md in doc. (apache#1558)
HDDS-4080. Create ZH translation of OzoneManager.md in doc. (apache#1541)
HDDS-4079. Create ZH translation of Containers.md in doc. (apache#1539)
HDDS-4184. Add Features menu for Chinese document. (apache#1547)
HDDS-4235. Ozone client FS path validation is not present in OFS. (apache#1582)
HDDS-4338. Fix the issue that SCM web UI banner shows "HDFS SCM". (apache#1583)
HDDS-4337. Implement RocksDB options cache for new datanode DB utilities. (apache#1544)
HDDS-4083. Create ZH translation of Recon.md in doc (apache#1575)
HDDS-4453. Replicate closed container for random selected datanodes. (apache#1574)
HDDS-4408: terminate Datanode when Datanode State Machine Thread got uncaught exception. (apache#1533)
HDDS-4443. Recon: Using Mysql database throws exception and fails startup (apache#1570)
HDDS-4315. Use Epoch to generate unique ObjectIDs (apache#1480)
HDDS-4455. Fix typo in README.md doc (apache#1578)
HDDS-4441. Add metrics for ACL related operations. (apache#1571)
HDDS-4437. Avoid unnecessary builder conversion in setting volume Quota/Owner request (apache#1564)
HDDS-4417. Simplify Ozone client code with configuration object (apache#1542)
HDDS-4363. Add metric to track the number of RocksDB open/close operations. (apache#1530)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cku328cku328cku328 approved these changes
@maobaolongmaobaolongAwaiting requested review from maobaolong

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuyang733@maobaolong@cku328