Skip to content

HDDS-4080. Create ZH translation of OzoneManager.md in doc. - #1541

Merged
cku328 merged 1 commit into
apache:masterfrom
yuyang733:HDDS-4080
Nov 15, 2020
Merged

HDDS-4080. Create ZH translation of OzoneManager.md in doc.#1541
cku328 merged 1 commit into
apache:masterfrom
yuyang733:HDDS-4080

Conversation

@yuyang733

@yuyang733yuyang733 commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Create ZH translation of OzoneManager.md in doc.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4080

runzhiwang
runzhiwang approved these changes Nov 10, 2020
View reviewed changes

@runzhiwangrunzhiwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cku328
cku328 requested changes Nov 10, 2020
View reviewed changes

@cku328cku328 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuyang733 for working on this.

I think we should ensure that some of the words are consistent with other existing documents.
Container -> 容器,
Volume -> 卷,
Bucket -> 桶
Key -> 键,etc.

And some suggestions on formatting.

Insert a space around an English word.
了解Ozone Manager -> 了解 Ozone Manager
Parentheses should use full width characters.
(Both formats exist in existing documents, should they be unified?)
分块上传 (Initiate, Complete…) -> 分块上传（Initiate, Complete…）

Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
@cku328cku328 added the documentation Improvements or additions to documentation label Nov 10, 2020
@yuyang733
yuyang733force-pushed the HDDS-4080 branch 2 times, most recently from 137e96c to 63f0f17CompareNovember 10, 2020 20:14
@yuyang733

yuyang733 commented Nov 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks @yuyang733 for working on this.

I think we should ensure that some of the words are consistent with other existing documents.
Container -> 容器,
Volume -> 卷,
Bucket -> 桶
Key -> 键,etc.

And some suggestions on formatting.

Insert a space around an English word.
了解Ozone Manager -> 了解 Ozone Manager
Parentheses should use full width characters.
(Both formats exist in existing documents, should they be unified?)
分块上传 (Initiate, Complete…) -> 分块上传（Initiate, Complete…）

done.

@yuyang733
yuyang733force-pushed the HDDS-4080 branch 3 times, most recently from e23ebc4 to c690886CompareNovember 12, 2020 12:30
cku328
cku328 requested changes Nov 13, 2020
View reviewed changes

@cku328cku328 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuyang733 for working on this.

Please add some images that are missing (OM Overview, Key Write and Key Reads).
I have some suggested changes. We can discuss it together.

Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
Comment threadhadoop-hdds/docs/content/concept/OzoneManager.zh.md Outdated
@yuyang733

yuyang733 commented Nov 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@cku328 Thanks for your comments and all are fixed. Can you help me to review it again?

cku328
cku328 approved these changes Nov 14, 2020
View reviewed changes

@cku328cku328 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1.
Thanks @yuyang733 for updating the patch.

@cku328
cku328 merged commit fcf0a4d into apache:masterNov 15, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Nov 18, 2020
@errose28
Merge branch 'master' into HDDS-4123
895219c
* master: (53 commits)
HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585)
HDDS-4442. Disable the location information of audit logger to reduce overhead (apache#1567)
HDDS-4441. Add metrics for ACL related operations.(Addendum for HA). (apache#1584)
HDDS-4081. Create ZH translation of StorageContainerManager.md in doc. (apache#1558)
HDDS-4080. Create ZH translation of OzoneManager.md in doc. (apache#1541)
HDDS-4079. Create ZH translation of Containers.md in doc. (apache#1539)
HDDS-4184. Add Features menu for Chinese document. (apache#1547)
HDDS-4235. Ozone client FS path validation is not present in OFS. (apache#1582)
HDDS-4338. Fix the issue that SCM web UI banner shows "HDFS SCM". (apache#1583)
HDDS-4337. Implement RocksDB options cache for new datanode DB utilities. (apache#1544)
HDDS-4083. Create ZH translation of Recon.md in doc (apache#1575)
HDDS-4453. Replicate closed container for random selected datanodes. (apache#1574)
HDDS-4408: terminate Datanode when Datanode State Machine Thread got uncaught exception. (apache#1533)
HDDS-4443. Recon: Using Mysql database throws exception and fails startup (apache#1570)
HDDS-4315. Use Epoch to generate unique ObjectIDs (apache#1480)
HDDS-4455. Fix typo in README.md doc (apache#1578)
HDDS-4441. Add metrics for ACL related operations. (apache#1571)
HDDS-4437. Avoid unnecessary builder conversion in setting volume Quota/Owner request (apache#1564)
HDDS-4417. Simplify Ozone client code with configuration object (apache#1542)
HDDS-4363. Add metric to track the number of RocksDB open/close operations. (apache#1530)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cku328cku328cku328 approved these changes
@runzhiwangrunzhiwangrunzhiwang approved these changes

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuyang733@cku328@runzhiwang