Skip to content

HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed - #2392

Merged
avijayanhwx merged 8 commits into
apache:masterfrom
symious:HDDS-5418
Jul 23, 2021
Merged

HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed#2392
avijayanhwx merged 8 commits into
apache:masterfrom
symious:HDDS-5418

Conversation

@symious

@symioussymious commented Jul 7, 2021

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Currently the "DatanodeDetails" are stored in Recon's local DB. Once a datanode has registered the content of DatanodeDetails won't be changed.

We met a scenario that datanodes' hostname is changed after running a while in Ozone cluster, the hostname in Recon's UI will still show the old hostnames.

This ticket proposes to send "reregisterCommand" to datanodes if the information of the datanode is changed.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5418

How was this patch tested?

Unit test

@symious

symious commented Jul 8, 2021

Copy link
Copy Markdown
ContributorAuthor

@avijayanhwx Could you help to check this PR?

@symioussymious changed the title HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changedWIP: HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changedJul 14, 2021
@avijayanhwx

avijayanhwx commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

@symious Are you still working on more changes in this PR? I see the title as 'WIP'.

@symious

symious commented Jul 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@avijayanhwx I did some changes on the commit to show more information like version, setup, etc.
Since the information is stored in NodeStateMap and doesn't support updates on this information, I think it's better to maintain an in-memory collection to store the updated datanodeDetails, besides I used the information from the in-memory collection to display on the Recon UI.

@symioussymious changed the title WIP: HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changedHDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changedJul 15, 2021
avijayanhwx
avijayanhwx reviewed Jul 19, 2021
View reviewed changes
Comment thread...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Comment threadhadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconNodeManager.java
Comment threadhadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/NodeEndpoint.java
avijayanhwx
avijayanhwx approved these changes Jul 23, 2021
View reviewed changes

@avijayanhwxavijayanhwx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations @symious. We can revisit the columns in UI if necessary.

@avijayanhwx
avijayanhwx merged commit 2759a9f into apache:masterJul 23, 2021
errose28 added a commit to errose28/ozone that referenced this pull request Jul 30, 2021
@errose28
Merge branch 'master' into HDDS-5432-no-downgrade-action
c0a585d
* master: (48 commits)
HDDS-5514. Skip check for UNHEALTHY containers for datanode finalize. (apache#2469)
HDDS-5279. OFS mkdir -p does not work when Volume is not pre-created (apache#2412)
HDDS-5328. Remove delete container command from admin CLI (apache#2456)
HDDS-5382. Increase default container report interval to 60 mins (apache#2363)
HDDS-5378 Add APIs to retrieve Namespace Summary from Recon (apache#2417)
HDDS-5466. Refactor BlockOutputStream. (apache#2442)
HDDS-5465. Delete redundant code when set、add and remove bucket acl (apache#2439)
HDDS-5184. Use separate DB profile for Datanodes. (apache#2214)
HDDS-5494. Reduce retry in Kubernetes test (apache#2461)
HDDS-5414. Data buffers incorrectly filtered for Ozone Insight (apache#2387)
HDDS-5450. Avoid refresh pipeline for S3 headObject (apache#2431)
HDDS-5500. New k3s version breaks kubernetes test (apache#2464)
HDDS-5489. Install OS-specific flekszible (apache#2462)
Multi-raft style placement with permutations for offline data generator (apache#2434)
HDDS-5484. Intermittent failure in TestReplicationManager#testMovePrerequisites (apache#2454)
HDDS-5443 Create and then recreate a bucket with a randomized name (apache#2436)
HDDS-5492. Disable failing kubernetes test (apache#2459)
HDDS-4330. Bootstrap new OM node (apache#1494)
HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed (apache#2392)
HDDS-5479. s3g bucket list failed when there is non-english key name. (apache#2450)
...
@szetszwoszetszwo mentioned this pull request May 15, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avijayanhwxavijayanhwxavijayanhwx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@symious@avijayanhwx