Uh oh!
There was an error while loading. Please reload this page.
HDDS-5450. Avoid refresh pipeline for S3 headObject - #2431
Conversation
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @bharatviswa504 for working on this. LGTM, I noticed only one minor code item.
Uh oh!
There was an error while loading. Please reload this page.
kerneltime
left a comment
There was a problem hiding this comment.
Some minor nits else LGTM
Uh oh!
There was an error while loading. Please reload this page.
| * @return OzoneKey which gives basic information about the key. | ||
| * @throws IOException | ||
| */ | ||
| public OzoneKey headObject(String key) throws IOException { |
There was a problem hiding this comment.
Rename to getOzoneKeyMetadata?
There was a problem hiding this comment.
There is getKey which does the same. To be clear, we can leave it as headObject. (As main use of this API is for S3 headObject)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bharatviswa504
commented
Jul 20, 2021
Thank You @adoroszlai and @kerneltime for the review. |
| .setBucketName(keyArgs.getBucketName()) | ||
| .setKeyName(keyArgs.getKeyName()) | ||
| .setRefreshPipeline(true) | ||
| .setSortDatanodesInPipeline(keyArgs.getSortDatanodes()) |
There was a problem hiding this comment.
Why is "sort datanodes" flag no longer set?
There was a problem hiding this comment.
It was a mistake, thanks for catching
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @bharatviswa504 for updating the patch.
adoroszlai
commented
Jul 27, 2021
Thanks @bharatviswa504 for the improvement and @kerneltime for the review. |
* master: (48 commits) HDDS-5514. Skip check for UNHEALTHY containers for datanode finalize. (apache#2469) HDDS-5279. OFS mkdir -p does not work when Volume is not pre-created (apache#2412) HDDS-5328. Remove delete container command from admin CLI (apache#2456) HDDS-5382. Increase default container report interval to 60 mins (apache#2363) HDDS-5378 Add APIs to retrieve Namespace Summary from Recon (apache#2417) HDDS-5466. Refactor BlockOutputStream. (apache#2442) HDDS-5465. Delete redundant code when set、add and remove bucket acl (apache#2439) HDDS-5184. Use separate DB profile for Datanodes. (apache#2214) HDDS-5494. Reduce retry in Kubernetes test (apache#2461) HDDS-5414. Data buffers incorrectly filtered for Ozone Insight (apache#2387) HDDS-5450. Avoid refresh pipeline for S3 headObject (apache#2431) HDDS-5500. New k3s version breaks kubernetes test (apache#2464) HDDS-5489. Install OS-specific flekszible (apache#2462) Multi-raft style placement with permutations for offline data generator (apache#2434) HDDS-5484. Intermittent failure in TestReplicationManager#testMovePrerequisites (apache#2454) HDDS-5443 Create and then recreate a bucket with a randomized name (apache#2436) HDDS-5492. Disable failing kubernetes test (apache#2459) HDDS-4330. Bootstrap new OM node (apache#1494) HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed (apache#2392) HDDS-5479. s3g bucket list failed when there is non-english key name. (apache#2450) ...
What changes were proposed in this pull request?
Avoid refresh pipeline for headObject API
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5450
How was this patch tested?
Added a test for new API. S3 test suite should test usage of headObject from s3 interface.