Skip to content

HDDS-6788. Sort Ozone list Status output for FSO buckets. - #3444

Merged
mukul1987 merged 13 commits into
apache:masterfrom
mukul1987:HDDS-6788
May 26, 2022
Merged

HDDS-6788. Sort Ozone list Status output for FSO buckets.#3444
mukul1987 merged 13 commits into
apache:masterfrom
mukul1987:HDDS-6788

Conversation

@mukul1987

@mukul1987mukul1987 commented May 23, 2022

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

With FSO buckets, S3 list keys output is not sorted.

Amazon S3 list Objects returning the output sorted.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html
Since listKeys relies on listStatus for FSO buckets, this jira proposes to make listStatus output sorted

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6788

How was this patch tested?

Added a new test to check for sorted output

rakeshadr
rakeshadr reviewed May 25, 2022
View reviewed changes

@rakeshadrrakeshadr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukul1987 for the patch. Added few comments, please go through it.

Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java
rakeshadr
rakeshadr approved these changes May 26, 2022
View reviewed changes

@rakeshadrrakeshadr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. Thanks @mukul1987 for the contribution!

@mukul1987
mukul1987 merged commit 2222be3 into apache:masterMay 26, 2022
@mukul1987
mukul1987 deleted the HDDS-6788 branch May 26, 2022 13:11
@aswinshakilaswinshakil mentioned this pull request Sep 27, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerneltimekerneltimekerneltime left review comments
@rakeshadrrakeshadrrakeshadr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mukul1987@kerneltime@rakeshadr