Uh oh!
There was an error while loading. Please reload this page.
HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl - #3747
Conversation
6a51441 to
f162f47Comparekerneltime
commented
Sep 19, 2022
kerneltime
commented
Sep 20, 2022
I think there needs to be a couple of more reviewers to approve this PR, there is a lot of code that is being deleted (which is good) but we need to be sure that it won't be missed. |
7cbfcfb to
615d168Compare615d168 to
f176017Comparemyskov
commented
Oct 4, 2022
@aswinshakil I resolved all conflicts. |
myskov
commented
Oct 6, 2022
since @aswinshakil hasn't been active for the last week, could you take a look at the PR please @kerneltime@adoroszlai ? |
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @myskov for the cleanup, LGTM. We can wait for @aswinshakil to take another look before merging this.
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @myskov. Approved it. For future reference, Please avoid force pushing as it makes it harder to review incremental changes.
adoroszlai
commented
Oct 6, 2022
Thanks @myskov for the patch, @aswinshakil, @kerneltime for the review. |
What changes were proposed in this pull request?
This PR removes dead code from omKeyManagerImpl class. The most significant part of the removed code is helper methods of listStatusFSO(), which is unreachable and has been removed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7211
How was this patch tested?
Existing unit and integration tests