Skip to content

PHOENIX-6263 : Close Table resources for certain workflows - #1015

Merged
gjacoby126 merged 1 commit into
apache:masterfrom
virajjasani:PHOENIX-6263-master
Dec 14, 2020
Merged

PHOENIX-6263 : Close Table resources for certain workflows#1015
gjacoby126 merged 1 commit into
apache:masterfrom
virajjasani:PHOENIX-6263-master

Conversation

@virajjasani

Copy link
Copy Markdown
Contributor

No description provided.

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 11smaster passed
+1 💚compile1m 2smaster passed
+1 💚checkstyle1m 16smaster passed
+1 💚javadoc0m 50smaster passed
+0 🆗spotbugs3m 6sphoenix-core in master has 967 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 11sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
-1 ❌checkstyle1m 17sphoenix-core: The patch generated 11 new + 2090 unchanged - 29 fixed = 2101 total (was 2119)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 49sthe patch passed
+1 💚spotbugs3m 29sthe patch passed
_ Other Tests _
-1 ❌unit187m 6sphoenix-core in the patch failed.
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
230m 55s
ReasonTests
Failed junit testsphoenix.end2end.UpsertSelectIT
phoenix.end2end.IndexVerificationOldDesignIT
phoenix.end2end.TableSnapshotReadsMapReduceIT
phoenix.end2end.SystemTablesCreationOnConnectionIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1015
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 133941b145b9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 16b0565
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/1/testReport/
Max. process+thread count6591 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall12m 36smaster passed
+1 💚compile0m 58smaster passed
+1 💚checkstyle1m 21smaster passed
+1 💚javadoc0m 43smaster passed
+0 🆗spotbugs2m 53sphoenix-core in master has 967 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall7m 27sthe patch passed
+1 💚compile0m 53sthe patch passed
+1 💚javac0m 52sthe patch passed
-1 ❌checkstyle1m 23sphoenix-core: The patch generated 27 new + 2074 unchanged - 45 fixed = 2101 total (was 2119)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 43sthe patch passed
+1 💚spotbugs3m 4sthe patch passed
_ Other Tests _
-1 ❌unit188m 5sphoenix-core in the patch failed.
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
224m 24s
ReasonTests
Failed junit testsphoenix.end2end.IndexVerificationOldDesignIT
phoenix.end2end.CountDistinctApproximateHyperLogLogIT
phoenix.end2end.SystemTablesCreationOnConnectionIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1015
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux eedc3ece89e9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 16b0565
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/2/testReport/
Max. process+thread count6597 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani

virajjasani commented Dec 14, 2020

Copy link
Copy Markdown
ContributorAuthor

IndexVerificationOldDesignIT and SystemTablesCreationOnConnectionIT seem consistently failing on master multibranch for few days.

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

@gjacoby126 could you please take a look?

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall13m 18smaster passed
+1 💚compile0m 57smaster passed
+1 💚checkstyle1m 21smaster passed
+1 💚javadoc0m 43smaster passed
+0 🆗spotbugs2m 52sphoenix-core in master has 967 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall7m 43sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
-1 ❌checkstyle1m 24sphoenix-core: The patch generated 11 new + 2090 unchanged - 29 fixed = 2101 total (was 2119)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 44sthe patch passed
+1 💚spotbugs3m 8sthe patch passed
_ Other Tests _
-1 ❌unit307m 42sphoenix-core in the patch failed.
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
345m 13s
ReasonTests
Failed junit testsphoenix.end2end.IndexVerificationOldDesignIT
phoenix.end2end.SystemTablesCreationOnConnectionIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1015
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux f7c76f1311c7 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 16b0565
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/3/testReport/
Max. process+thread count6654 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1015/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Syscat test failure looks genuine but doesn't seem related to this patch

@gjacoby126
gjacoby126 merged commit 5a7864c into apache:masterDec 14, 2020
@virajjasani
virajjasani deleted the PHOENIX-6263-master branch December 15, 2020 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@virajjasani@stoty@gjacoby126