Phoenix 331- Phoenix-Hive initial commit

[nmaillard]

No description provided.

[ddraj]

Please remove these tags. This should just be a javadoc explaining the high level functionality of the class. Look at some other class in Phoenix if you want to get an idea...

[mravi]

Thanks a lot for the patch @nmaillard . Couple of additional minor fixes

1. Couple of classes have your name as the author. Please remove it.
2. Certain classes have lot of commented code .

[ddraj]

Who does the datatype conversion from Hive to Phoenix?

[nmaillard]

The type conversion is all done in HiveTypeUtil, HiveType2PdataType does Hive to phoenix.
In PhoenixHiveDBWritable the write class leverage that information to create the prepared statement. T extends DBWritable and is a PhoenixHiveDBWritable in a this instance.
Some complex types like Array are still missing, this will be follow up work

[JamesRTaylor]

Why is this code repeated, as it's in the base MR integration already?

[JamesRTaylor]

This is looking good, @nmaillard. Still some copy/paste code that we should aim to cleanup. Also, take care that no exceptions are swallowed. Wrap checked exceptions in a SQLException if it's declared in the method and otherwise wrap in a RuntimeException and throw it. Also, make sure to remove or convert all System.out.println calls to logging instead.

[JamesRTaylor]

@mravi - would you mind giving this a review?

[stoty]

Already merged.
(And since has been factored out to the phoenix-connectors repo)