Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6293 PHOENIX-6193 breaks projects depending on the phoenix-cl… - #1052
Closed
stoty wants to merge 1 commit into
Closed
PHOENIX-6293 PHOENIX-6193 breaks projects depending on the phoenix-cl…#1052stoty wants to merge 1 commit into
stoty wants to merge 1 commit into
Conversation
stoty
commented
Jan 4, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 4, 2021
ContributorAuthor
Pushed new version to fix RAT confusion |
| <groupId>org.apache.rat</groupId> | ||
| <artifactId>apache-rat-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> |
Contributor
There was a problem hiding this comment.
And phoenix-client is going to run RAT check even in the presence of this right? It overrides plugin from parent pom?
ContributorAuthor
There was a problem hiding this comment.
No it won't. We could re-enable RAT by specifying skip=false in the submodules, but there is nothing to audit in either submodule, they both have only a single pom.xml file in them.
Contributor
There was a problem hiding this comment.
Oh yes, there is nothing in sub modules either.
Contributor
+1 (non-binding) with RAT fix |
stoty
commented
Jan 4, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
joshelser
approved these changes
Jan 4, 2021
joshelser
left a comment
Member
There was a problem hiding this comment.
This does the trick! Thanks, Istvan. I had no clue why it wasn't finding this module in the pqs build :)
stoty
commented
Jan 4, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ient artifact