PHOENIX-6295 : Fix non-static inner classes for better memory utilization

[virajjasani]

4.x backport of PR #1053

[gjacoby126]

+1

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 11s	4.x passed
+1 💚	compile	1m 4s	4.x passed
+1 💚	checkstyle	2m 21s	4.x passed
+1 💚	javadoc	0m 47s	4.x passed
+0 🆗	spotbugs	3m 17s	phoenix-core in 4.x has 962 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 3s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
-1 ❌	checkstyle	2m 20s	phoenix-core: The patch generated 60 new + 6925 unchanged - 64 fixed = 6985 total (was 6989)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 47s	the patch passed
-1 ❌	spotbugs	3m 32s	phoenix-core generated 1 new + 947 unchanged - 15 fixed = 948 total (was 962)
		_ Other Tests _
-1 ❌	unit	190m 30s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		231m 58s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.hbase.index.covered.update.IndexUpdateManager$MutationComparator implements Comparator but not Serializable At IndexUpdateManager.java:Serializable At IndexUpdateManager.java:[lines 47-94]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1054
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux e0ea573d2332 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / 5ad54f9
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/testReport/
Max. process+thread count	5696 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 28s	4.x passed
+1 💚	compile	1m 4s	4.x passed
+1 💚	checkstyle	2m 20s	4.x passed
+1 💚	javadoc	0m 48s	4.x passed
+0 🆗	spotbugs	3m 25s	phoenix-core in 4.x has 962 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 54s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
-1 ❌	checkstyle	2m 21s	phoenix-core: The patch generated 60 new + 6924 unchanged - 64 fixed = 6984 total (was 6988)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 48s	the patch passed
+1 💚	spotbugs	3m 25s	phoenix-core generated 0 new + 947 unchanged - 15 fixed = 947 total (was 962)
		_ Other Tests _
-1 ❌	unit	195m 30s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		241m 17s

Reason	Tests
Failed junit tests	phoenix.end2end.index.PartialIndexRebuilderIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1054
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 8b231ff33d8e 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / 16c0bb4
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/testReport/
Max. process+thread count	6193 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.