Skip to content

PHOENIX-1661 Implement built-in functions for JSON - #102

Closed
wlei-llvm wants to merge 27 commits into
apache:jsonfrom
wlei-llvm:json
Closed

PHOENIX-1661 Implement built-in functions for JSON#102
wlei-llvm wants to merge 27 commits into
apache:jsonfrom
wlei-llvm:json

Conversation

@wlei-llvm

Copy link
Copy Markdown

Add some built-in functions for JSON : JsonArrayElementsFunction.java JsonArrayLengthFunction.java JsonEachFunction.java JsonObjectKeysFunction.java JsonPopulateRecordFunction.java JsonPopulateRecordSetFunction.java. ArrayToJsonFunction.java

Add end2end test files.

Modify file PhoenixJson.java to which I added some helper methods.

@JamesRTaylor@twdsilva@AakashPradeep

wlei-llvmand others added 25 commits March 21, 2015 23:32
add a function to support "ArrayToJson" function as a build-in function for JSON
a simple test for testing ArrayToJsonFunction
Implement built-in functions for JSON
PHOENIX-1661 Implement built-in functions for JSON
Conflicts:
phoenix-core/src/main/java/org/apache/phoenix/schema/json/PhoenixJson.java
2 add some javadocs and commemts in the code
3 define variables only at the place where it is used
4 use StringBuilder replace "+" operator
5 rename some method name in PhoenixJson
6 change some helper methods level in JsonFunctionTest
add End2End Test
add SQLExceptionCode
fix bugs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and other occurences of the same) should return true, meaning "yes, there was enough information available for me to evaluate this expression, but it returned null (which is what a ptr.getLength() of 0 means)"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename test as suggested above

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to json_each_text (do not implement json_each)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wlei-llvm@twdsilva@JamesRTaylor@AakashPradeep