Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests - #1078
Closed
stoty wants to merge 1 commit into
Closed
PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests#1078stoty wants to merge 1 commit into
stoty wants to merge 1 commit into
Conversation
virajjasani
approved these changes
Jan 8, 2021
| </goals> | ||
| </execution> | ||
| <execution> | ||
| <id>HBaseManagedTimeTests</id> |
Contributor
There was a problem hiding this comment.
Oh this is not even being used
ContributorAuthor
There was a problem hiding this comment.
Must have been copied from HBase, then lurked here for years...
ContributorAuthor
There was a problem hiding this comment.
Looking at again, this still might have effect on Pherf.
It probably should be purged, but not today.
stoty
commented
Jan 8, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 8, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 8, 2021
ContributorAuthor
Last test also had a setup error, but it wasn't the timeout error. |
| private static long timestamp; | ||
| public static long nextTimestamp() { | ||
| public static synchronized long nextTimestamp() { |
Contributor
There was a problem hiding this comment.
Looks like this is recent addition right? We could include deletePriorMetaData() too?
Contributor
There was a problem hiding this comment.
Or maybe just synchronizing deletePriorMetaData() could be enough as it would cover deletePriorTables(), nextTimestamp() and deletePriorSchemas()?
ContributorAuthor
There was a problem hiding this comment.
Those are only used when running the tests on a real cluster, which feature is broken in many ways.
Almost no-one uses it, and it doesn't affect the maven test suite.
And by the pherf tests, which really should be fixed :)
It doesn't hurt to synchronize it.
ContributorAuthor
Set all stateful priected static methods to synchronized as well. |
virajjasani
commented
Jan 9, 2021
Contributor
FWIW, synchronizing all these methods could be subtask of PHOENIX-6288 and good to directly check for results in multibranch? In the meanwhile we can keep PHOENIX-6288 opened until we get 2-3 multibranch build results without init errors. WDYT @stoty ? |
virajjasani
commented
Jan 9, 2021
Contributor
Although PR build#4 should finish sometime soon hopefully. |
stoty
commented
Jan 9, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stotyforce-pushed
the
HTUsync
branch
3 times, most recently
from
January 9, 2021 20:19
bbc7962 to
f8a6debComparestoty
commented
Jan 10, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 10, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stotyforce-pushed
the
HTUsync
branch
3 times, most recently
from
January 19, 2021 07:45
408cf22 to
f470256Comparestoty
commented
Jan 19, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stotyforce-pushed
the
HTUsync
branch
3 times, most recently
from
January 19, 2021 11:36
be59311 to
5ed35ebComparestoty
commented
Jan 19, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 19, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stotyforce-pushed
the
HTUsync
branch
2 times, most recently
from
January 20, 2021 07:06
a4f02a6 to
2baf251Comparestoty
commented
Jan 20, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 21, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 22, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.