Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6329 Eliminate or serialize minicluster restart operations in… - #1101
Closed
stoty wants to merge 1 commit into
Closed
PHOENIX-6329 Eliminate or serialize minicluster restart operations in…#1101stoty wants to merge 1 commit into
stoty wants to merge 1 commit into
Conversation
stoty
commented
Jan 19, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stotyforce-pushed
the
PHOENIX-6329-4.x
branch
3 times, most recently
from
January 19, 2021 16:48
6b2e5ad to
a1b2ee4Comparestoty
commented
Jan 20, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Jan 21, 2021
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, assuming that usage data shows this makes the tests more stable. Thanks @stoty
Contributor
With this, we have perf advantage over #1080 but still full build took 4h16m. I believe a couple more build runs could provide clear results on both PRs. |
stoty
commented
Jan 22, 2021
ContributorAuthor
Comparing the ASF jenkins runtimes is not trivial. We've got both 16 and 24 core machines in the pool, and there may or may not be another task running in parallel. |
stoty
commented
Jan 22, 2021
ContributorAuthor
The last build had a successful test run (the maven shading bug caused a build failure, but that's a different issue) |
Contributor
Got it, Thanks. I think it makes sense, anyways when I tried in my VM with and without #1080 , the difference was apparent. Anyways, synchronizing the key functionality of starting and shuting down miniCluster is necessary. Agree with moving forward with this patch after we have QA result for updated PR.
Great. |
stoty
commented
Jan 22, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Integration tests