Skip to content

PHOENIX-6343 : Phoenix allows duplicate column names when one of them is a primary key - #1117

Merged
virajjasani merged 1 commit into
apache:masterfrom
virajjasani:PHOENIX-6343-master
Feb 14, 2021
Merged

PHOENIX-6343 : Phoenix allows duplicate column names when one of them is a primary key#1117
virajjasani merged 1 commit into
apache:masterfrom
virajjasani:PHOENIX-6343-master

Conversation

@virajjasani

@virajjasanivirajjasani commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@stoty

stoty commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 11smaster passed
+0hbaserecompile24m 10sHBase recompiled.
+1 💚compile1m 4smaster passed
+1 💚checkstyle1m 17smaster passed
+1 💚javadoc0m 53smaster passed
+0 🆗spotbugs3m 17sphoenix-core in master has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall10m 13sthe patch passed
+0hbaserecompile21m 24sHBase recompiled.
+1 💚compile1m 16sthe patch passed
+1 💚javac1m 16sthe patch passed
-1 ❌checkstyle1m 30sphoenix-core: The patch generated 1 new + 2869 unchanged - 0 fixed = 2870 total (was 2869)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 1sthe patch passed
+1 💚spotbugs4m 2sthe patch passed
_ Other Tests _
-1 ❌unit2m 1sphoenix-core in the patch failed.
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
66m 1s
ReasonTests
Failed junit testsphoenix.compile.SelectStatementRewriterTest
phoenix.query.ExplainPlanTextTest
phoenix.util.json.JsonUpsertExecutorTest
phoenix.schema.MutationTest
phoenix.jdbc.PhoenixDriverTest
phoenix.compile.QueryMetaDataTest
phoenix.compile.PostIndexDDLCompilerTest
phoenix.index.VerifySingleIndexRowTest
phoenix.query.ParallelIteratorsSplitTest
phoenix.compile.WhereCompilerTest
phoenix.compile.CursorCompilerTest
phoenix.query.QueryPlanTest
phoenix.compile.JoinQueryCompilerTest
phoenix.query.OrderByTest
phoenix.util.ScanUtilTest
phoenix.query.PropertyPolicyProviderTest
phoenix.schema.RowKeySchemaTest
phoenix.expression.NullValueTest
phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest
phoenix.compile.ViewCompilerTest
phoenix.compile.QueryOptimizerTest
phoenix.mapreduce.util.IndexColumnNamesTest
phoenix.mapreduce.util.PhoenixConfigurationUtilTest
phoenix.jdbc.PhoenixResultSetMetadataTest
phoenix.mapreduce.index.IndexScrutinyTableOutputTest
phoenix.util.csv.StringToArrayConverterTest
phoenix.compile.TenantSpecificViewIndexCompileTest
phoenix.compile.LimitCompilerTest
phoenix.compile.StatementHintsCompilationTest
phoenix.util.PhoenixRuntimeTest
phoenix.schema.RowKeyValueAccessorTest
phoenix.expression.RoundFloorCeilExpressionsTest
phoenix.index.PrepareIndexMutationsForRebuildTest
phoenix.hbase.index.covered.NonTxIndexBuilderTest
phoenix.jdbc.PhoenixPreparedStatementTest
phoenix.compile.HavingCompilerTest
phoenix.index.IndexMaintainerTest
phoenix.query.KeyRangeClipTest
phoenix.util.PhoenixEncodeDecodeTest
phoenix.compile.QueryCompilerTest
phoenix.compile.WhereOptimizerTest
phoenix.query.ScannerLeaseRenewalTest
phoenix.index.IndexScrutinyMapperTest
phoenix.util.csv.CsvUpsertExecutorTest
phoenix.schema.MetaDataClientTest
phoenix.iterate.AggregateResultScannerTest
phoenix.compile.CreateTableCompilerTest
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux ef3b73854e0d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 79c66fd
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/testReport/
Max. process+thread count428 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 6smaster passed
+0hbaserecompile24m 1sHBase recompiled.
+1 💚compile1m 2smaster passed
+1 💚checkstyle1m 19smaster passed
+1 💚javadoc0m 52smaster passed
+0 🆗spotbugs3m 16sphoenix-core in master has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall9m 59sthe patch passed
+0hbaserecompile20m 31sHBase recompiled.
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
-1 ❌checkstyle1m 17sphoenix-core: The patch generated 16 new + 3016 unchanged - 12 fixed = 3032 total (was 3028)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 51sthe patch passed
+1 💚spotbugs3m 38sthe patch passed
_ Other Tests _
-1 ❌unit1m 48sphoenix-core in the patch failed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
59m 31s
ReasonTests
Failed junit testsphoenix.schema.MutationTest
phoenix.compile.QueryOptimizerTest
phoenix.compile.QueryCompilerTest
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 5e54e04c540e 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 79c66fd
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/2/testReport/
Max. process+thread count424 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 12smaster passed
+0hbaserecompile22m 6sHBase recompiled.
+1 💚compile1m 2smaster passed
+1 💚checkstyle1m 47smaster passed
+1 💚javadoc0m 53smaster passed
+0 🆗spotbugs3m 7sphoenix-core in master has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 10sthe patch passed
+0hbaserecompile18m 36sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle1m 50sphoenix-core: The patch generated 24 new + 3016 unchanged - 13 fixed = 3040 total (was 3029)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 50sthe patch passed
+1 💚spotbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit1m 36sphoenix-core in the patch failed.
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
59m 15s
ReasonTests
Failed junit testsphoenix.compile.QueryOptimizerTest
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux edf57c85ffd8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / c9e05f0
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/3/testReport/
Max. process+thread count464 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall16m 17smaster passed
+0hbaserecompile23m 22sHBase recompiled.
+1 💚compile1m 2smaster passed
+1 💚checkstyle1m 37smaster passed
+1 💚javadoc0m 56smaster passed
+0 🆗spotbugs3m 16sphoenix-core in master has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 24sthe patch passed
+0hbaserecompile18m 9sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle1m 35sphoenix-core: The patch generated 12 new + 3028 unchanged - 1 fixed = 3040 total (was 3029)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 50sthe patch passed
+1 💚spotbugs3m 23sthe patch passed
_ Other Tests _
-1 ❌unit102m 1sphoenix-core in the patch failed.
+1 💚asflicense0m 44sThe patch does not generate ASF License warnings.
158m 24s
ReasonTests
Failed junit testsphoenix.monitoring.PhoenixLoggingMetricsIT
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 89cede565fca 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / c9e05f0
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/4/testReport/
Max. process+thread count13745 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/4/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall15m 12smaster passed
+0hbaserecompile22m 43sHBase recompiled.
+1 💚compile1m 4smaster passed
+1 💚checkstyle1m 47smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 1sphoenix-core in master has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 28sthe patch passed
+0hbaserecompile18m 15sHBase recompiled.
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
-1 ❌checkstyle1m 34sphoenix-core: The patch generated 24 new + 3016 unchanged - 13 fixed = 3040 total (was 3029)
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚javadoc0m 57sthe patch passed
+1 💚spotbugs3m 24sthe patch passed
_ Other Tests _
-1 ❌unit112m 17sphoenix-core in the patch failed.
+1 💚asflicense0m 42sThe patch does not generate ASF License warnings.
168m 20s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
phoenix.end2end.PermissionNSEnabledIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 42f84d785271 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / c9e05f0
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/5/testReport/
Max. process+thread count8123 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/5/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ankitsinghal

ankitsinghal commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

having duplicate column names at different hierarchy is not fine? Like below table shouldn't be correct or not allowed?
CREATE TABLE multiple_columns_with_same_name(id integer primary key, id /*comment , it will be "0".id*/ integer, "cf1".id integer,"cf2".id integer);

@stoty

stoty commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

In your example, how would you address the pk id ?
What would / should rs.getString("id") return ?
To be consistent, it should be "0".id. However, that leaves no way to address pk.id.

This is the reason that specifically PK and the default cf should not have identical names.

@ankitsinghal

ankitsinghal commented Jan 29, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
What would / should rs.getString("id") return ?
To be consistent, it should be "0".id. However, that leaves no way to address pk.id.
This is the reason that specifically PK and the default cf should not have identical names.

yes, it makes sense, we can't force users to refer every default cf column with "0." and primary columns directly. Thanks

@virajjasani

virajjasani commented Jan 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks @ankitsinghal for taking a look. Btw somewhat related discussion happened on #1118 yesterday since I raised both master and backport PRs together. I agree that column with user specified CF should be allowed same column name as pk (or non-pk from different CF) but it's just that allowing the same in default CF makes it bit complicated.
Thanks

@stoty

stoty commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall17m 30smaster passed
+0hbaserecompile24m 58sHBase recompiled.
+1 💚compile1m 6smaster passed
+1 💚checkstyle1m 16smaster passed
+1 💚javadoc0m 55smaster passed
+0 🆗spotbugs3m 30sphoenix-core in master has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall10m 11sthe patch passed
+0hbaserecompile20m 42sHBase recompiled.
+1 💚compile1m 11sthe patch passed
+1 💚javac1m 11sthe patch passed
-1 ❌checkstyle1m 25sphoenix-core: The patch generated 12 new + 3027 unchanged - 1 fixed = 3039 total (was 3028)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 1sthe patch passed
+1 💚spotbugs3m 52sthe patch passed
_ Other Tests _
+1 💚unit112m 25sphoenix-core in the patch passed.
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
171m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 2712bd6e898f 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 22f7d41
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/6/testReport/
Max. process+thread count9959 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/6/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall15m 28smaster passed
+0hbaserecompile22m 58sHBase recompiled.
+1 💚compile1m 2smaster passed
+1 💚checkstyle1m 47smaster passed
+1 💚javadoc0m 52smaster passed
+0 🆗spotbugs3m 8sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 5sthe patch passed
+0hbaserecompile17m 45sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle1m 51sphoenix-core: The patch generated 24 new + 3015 unchanged - 13 fixed = 3039 total (was 3028)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 52sthe patch passed
+1 💚spotbugs3m 10sthe patch passed
_ Other Tests _
-1 ❌unit103m 50sphoenix-core in the patch failed.
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
164m 26s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1117
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux ef34a749f573 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 9e90779
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/7/testReport/
Max. process+thread count14316 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/7/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit 6ed3caf into apache:masterFeb 14, 2021
virajjasani added a commit that referenced this pull request Feb 14, 2021
@virajjasani
PHOENIX-6343: Phoenix allows duplicate column names when one of them…
b1665b7
… is a primary key (#1117)
Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org>
@virajjasani
virajjasani deleted the PHOENIX-6343-master branch September 24, 2021 12:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@virajjasani@stoty@ankitsinghal