PHOENIX-6343 : Phoenix allows duplicate column names when one of them is a primary key by virajjasani · Pull Request #1118 · apache/phoenix

virajjasani · 2021-01-28T06:01:48Z

No description provided.

stoty · 2021-01-28T06:26:10Z

 assertTrue(splits.size() > 0);
 }

+ @Test


Can you add a test for adding the identical column with an alter table statement ?

Done in the same test

stoty · 2021-01-28T06:43:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 17s	4.x passed
+1 💚	compile	1m 1s	4.x passed
+1 💚	checkstyle	1m 37s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	3m 0s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 51s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
-1 ❌	checkstyle	1m 39s	phoenix-core: The patch generated 2 new + 2856 unchanged - 1 fixed = 2858 total (was 2857)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
+1 💚	spotbugs	3m 9s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 23s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		40m 46s

Reason	Tests
Failed junit tests	phoenix.query.QueryPlanTest
	phoenix.util.json.JsonUpsertExecutorTest
	phoenix.index.IndexScrutinyMapperTest
	phoenix.compile.QueryOptimizerTest
	phoenix.query.ExplainPlanTextTest
	phoenix.schema.RowKeyValueAccessorTest
	phoenix.compile.QueryMetaDataTest
	phoenix.schema.MutationTest
	phoenix.mapreduce.index.IndexScrutinyTableOutputTest
	phoenix.query.PropertyPolicyProviderTest
	phoenix.schema.MetaDataClientTest
	phoenix.schema.RowKeySchemaTest
	phoenix.jdbc.PhoenixResultSetMetadataTest
	phoenix.index.VerifySingleIndexRowTest
	phoenix.util.PhoenixRuntimeTest
	phoenix.compile.LimitCompilerTest
	phoenix.query.OrderByTest
	phoenix.compile.CreateTableCompilerTest
	phoenix.util.ScanUtilTest
	phoenix.util.csv.StringToArrayConverterTest
	phoenix.index.IndexMaintainerTest
	phoenix.query.KeyRangeClipTest
	phoenix.jdbc.PhoenixPreparedStatementTest
	phoenix.compile.StatementHintsCompilationTest
	phoenix.query.ParallelIteratorsSplitTest
	phoenix.expression.RoundFloorCeilExpressionsTest
	phoenix.jdbc.PhoenixDriverTest
	phoenix.index.PrepareIndexMutationsForRebuildTest
	phoenix.util.csv.CsvUpsertExecutorTest
	phoenix.util.PhoenixEncodeDecodeTest
	phoenix.query.ScannerLeaseRenewalTest
	phoenix.compile.HavingCompilerTest
	phoenix.compile.TenantSpecificViewIndexCompileTest
	phoenix.compile.WhereOptimizerTest
	phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest
	phoenix.compile.QueryCompilerTest
	phoenix.mapreduce.util.PhoenixConfigurationUtilTest
	phoenix.compile.SelectStatementRewriterTest
	phoenix.compile.CursorCompilerTest
	phoenix.compile.PostIndexDDLCompilerTest
	phoenix.iterate.AggregateResultScannerTest
	phoenix.compile.WhereCompilerTest
	phoenix.hbase.index.covered.NonTxIndexBuilderTest
	phoenix.compile.ViewCompilerTest
	phoenix.expression.NullValueTest
	phoenix.compile.JoinQueryCompilerTest
	phoenix.mapreduce.util.IndexColumnNamesTest

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux c38352c577bc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `44d4402`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/testReport/
Max. process+thread count	463 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-01-28T09:18:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 39s	4.x passed
+1 💚	compile	1m 1s	4.x passed
+1 💚	checkstyle	1m 42s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	3m 2s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 54s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	1m 41s	phoenix-core: The patch generated 4 new + 3014 unchanged - 0 fixed = 3018 total (was 3014)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 11s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 32s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		37m 25s

Reason	Tests
Failed junit tests	phoenix.compile.QueryOptimizerTest
	phoenix.schema.MutationTest
	phoenix.compile.QueryCompilerTest

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux baef993b88fe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `44d4402`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/testReport/
Max. process+thread count	464 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-01-28T09:24:30Z

Shall we disable allowing same column name as primary key under any columnFamily or should we just disable it under default columnFamily?

stoty · 2021-01-28T09:47:38Z

Good question.
I don't know enough about how we handle the PKs to answer it.

Do we store the PK field(s) in actual cell, or are they only present in the rowkey ?
What happens when you specify a CF for a PK field ? is it even valid ?

This should be easy enough to check with hbase shell.
I'll try to check later today if you can't answer these of the top of your head.

virajjasani · 2021-01-28T11:55:15Z

Nice points.

Do we store the PK field(s) in actual cell, or are they only present in the rowkey ?

For user created tables, their pk (and non-pk) columns are actually rowkeys in SYSTEM.CATALOG. The cells represent specific properties like DATA_TYPE, NULLABLE etc.

What happens when you specify a CF for a PK field ? is it even valid ?

I think we can't specify CF for PK. We have this special Exception for it: PRIMARY_KEY_WITH_FAMILY_NAME

Based on some unit tests written very initially, it seems we do allow creating same column name (with user defined columnFamily) as Pk column name, but that is the very reason why the same would apply to default columnFamily and hence, any user created table can have Pk and non-Pk column names same.

stoty · 2021-01-28T12:00:58Z

Thanks for checking.

In this case, IMO we should handle this like the standard columns.

If we allow the same name in different column families, then we should only forbid matching names in the default CF.
If we don't allow the same name in differenct CFs, then we should forbid matching names in all CFs.

virajjasani · 2021-01-28T12:24:34Z

It seems from visibility viewpoint, the problem remains same. Even with user defined CF, we see same column name as pk column.

> create table tab3 (col1 INTEGER NOT NULL PRIMARY KEY, col2 INTEGER, a.col1 INTEGER);
No rows affected (1.254 seconds)
> select * from tab3;
+-------+-------+-------+
| COL1 | COL2 | COL1 |
+-------+-------+-------+
+-------+-------+-------+
> create table table4 (col1 INTEGER NOT NULL PRIMARY KEY, col2 INTEGER, a.col1 INTEGER, b.col1 INTEGER);
No rows affected (1.254 seconds)
0: jdbc:phoenix:> select * from table4;
+-------+-------+-------+-------+
| COL1 | COL2 | COL1 | COL1 |
+-------+-------+-------+-------+
+-------+-------+-------+-------+
No rows selected (0.01 seconds)

stoty · 2021-01-28T12:31:42Z

That is more of an sqlline/presentation problem.
You can address the different columns via the JDBC API unambigously ( I hope, though I didn't test this), while it's not possible in the PK vs default CF case.

Based on this, we should only disallow the PK names in the default CF.

stoty · 2021-01-28T12:33:48Z

i.e you can get rs.getString("cfa.a"), and rs.getString("cfb.a"), but if you cannot get do the same for PK.a vs default cf.a .

virajjasani · 2021-01-28T12:35:01Z

Right, mostly it is representation problem. You are right, we should stick to default CF.

gjacoby126

One nit, otherwise lgtm

gjacoby126 · 2021-01-28T14:41:52Z

+ String viewName = generateUniqueName();
+ try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ try {
+ conn.createStatement().execute(String.format("CREATE TABLE %s"


nit: Would be good if before each case there was a brief comment explaining it -- e.g "Same column name, different column type" for the third one.

Definitely, on it.

Done. Thanks @gjacoby126

gjacoby126

+1, assuming tests pass. Thanks @virajjasani

stoty · 2021-01-28T15:16:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 31s	4.x passed
+1 💚	compile	1m 1s	4.x passed
+1 💚	checkstyle	1m 33s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	3m 0s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 49s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
-1 ❌	checkstyle	1m 43s	phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 12s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 31s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		36m 57s

Reason	Tests
Failed junit tests	phoenix.compile.QueryOptimizerTest

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux fa0bb6a2a1d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `44d4402`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/testReport/
Max. process+thread count	463 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-01-28T15:54:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 40s	4.x passed
+1 💚	compile	1m 1s	4.x passed
+1 💚	checkstyle	1m 40s	4.x passed
+1 💚	javadoc	0m 44s	4.x passed
+0 🆗	spotbugs	2m 59s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 52s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	1m 43s	phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
+1 💚	spotbugs	3m 9s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 31s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		37m 13s

Reason	Tests
Failed junit tests	phoenix.compile.QueryOptimizerTest

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 1c873547c43e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `44d4402`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/testReport/
Max. process+thread count	491 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… is a primary key

virajjasani · 2021-01-28T18:27:31Z

Latest changes include some minor changes in PhoenixLoggingMetricsIT and QueryOptimizerTest. Let's see how QA goes (build#6 onwards).

stoty · 2021-01-28T18:51:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 26s	4.x passed
+1 💚	compile	1m 2s	4.x passed
+1 💚	checkstyle	1m 41s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	2m 58s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 3s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	1m 38s	phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
+1 💚	spotbugs	3m 10s	the patch passed
		_ Other Tests _
-1 ❌	unit	138m 16s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		175m 51s

Reason	Tests
Failed junit tests	phoenix.monitoring.PhoenixLoggingMetricsIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux b3ffd620027c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `44d4402`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/testReport/
Max. process+thread count	5684 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/5/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-01-28T21:56:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 38s	4.x passed
+1 💚	compile	1m 5s	4.x passed
+1 💚	checkstyle	1m 28s	4.x passed
+1 💚	javadoc	0m 49s	4.x passed
+0 🆗	spotbugs	3m 10s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 50s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
-1 ❌	checkstyle	1m 36s	phoenix-core: The patch generated 13 new + 3013 unchanged - 2 fixed = 3026 total (was 3015)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	1m 0s	the patch passed
+1 💚	spotbugs	4m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	143m 39s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		182m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux b54fec3632d7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `44d4402`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/testReport/
Max. process+thread count	5801 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/6/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-02-10T16:04:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 43s	4.x passed
+1 💚	compile	1m 1s	4.x passed
+1 💚	checkstyle	1m 41s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	3m 1s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 43s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
-1 ❌	checkstyle	1m 45s	phoenix-core: The patch generated 12 new + 3013 unchanged - 1 fixed = 3025 total (was 3014)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	195m 53s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		234m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1118
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux e208e60b5d7f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `883170e`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/testReport/
Max. process+thread count	5635 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1118/7/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… is a primary key (#1118) Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org>

stoty reviewed Jan 28, 2021
View reviewed changes

gjacoby126 requested changes Jan 28, 2021
View reviewed changes

gjacoby126 approved these changes Jan 28, 2021
View reviewed changes

PHOENIX-6343: Phoenix allows duplicate column names when one of them…
f366dd6
… is a primary key

virajjasani mentioned this pull request Jan 29, 2021
PHOENIX-6343 : Phoenix allows duplicate column names when one of them is a primary key #1117
Merged

virajjasani merged commit ec386e9 into apache:4.xFeb 14, 2021

asfgit pushed a commit that referenced this pull request Feb 15, 2021
PHOENIX-6343: Phoenix allows duplicate column names when one of them…
47a52bc
… is a primary key (#1118) Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org>

Uh oh!

Conversation

virajjasani commented Jan 28, 2021

Uh oh!

stotyJan 28, 2021

Choose a reason for hiding this comment

Uh oh!

virajjasaniJan 28, 2021

Choose a reason for hiding this comment

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

virajjasani commented Jan 28, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

virajjasani commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

virajjasani commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

virajjasani commented Jan 28, 2021

Uh oh!

gjacoby126 left a comment

Choose a reason for hiding this comment

Uh oh!

gjacoby126Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

virajjasaniJan 28, 2021

Choose a reason for hiding this comment

Uh oh!

virajjasaniJan 28, 2021

Choose a reason for hiding this comment

Uh oh!

gjacoby126 left a comment

Choose a reason for hiding this comment

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

virajjasani commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

stoty commented Jan 28, 2021

Uh oh!

stoty commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

virajjasani commented Jan 28, 2021•
edited
Loading